mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 22:58:07 +02:00
Code Activity
pdf.js/web
History
Jonas Jenwald 81e99da440 Check that the annotationLayer is still active before injecting inferred links (PR 19110 follow-up) 
This issue is quite difficult to trigger reliably, however it's possible for rendering to have been aborted and thus for the annotationLayer to have been removed once we're invoking `injectLinkAnnotations`. In that case, an Error is thrown[1].

The way that I'm able to *intermittently* trigger this is by:
 - Loading http://localhost:8888/web/viewer.html?file=/test/pdfs/pdf.pdf#disableHistory=true
 - Enable "Wrapped Srolling" mode.
 - Quickly zoom out, to the minimum zoom level.

---
[1]
```
renderView: TypeError: can't access property "injectLinkAnnotations", this.annotationLayer is null
    resultPromise http://localhost:8888/web/pdf_page_view.js:1116
    draw http://localhost:8888/web/pdf_page_view.js:1099
    renderView http://localhost:8888/web/pdf_rendering_queue.js:196
    forceRendering http://localhost:8888/web/pdf_viewer.js:1849
    promise callback*forceRendering http://localhost:8888/web/pdf_viewer.js:1848
    renderHighestPriority http://localhost:8888/web/pdf_rendering_queue.js:79
    renderView http://localhost:8888/web/pdf_rendering_queue.js:198
    renderView http://localhost:8888/web/pdf_rendering_queue.js:197
    forceRendering http://localhost:8888/web/pdf_viewer.js:1849
    promise callback*forceRendering http://localhost:8888/web/pdf_viewer.js:1848
    renderHighestPriority http://localhost:8888/web/pdf_rendering_queue.js:79
    renderView http://localhost:8888/web/pdf_rendering_queue.js:198
    renderView http://localhost:8888/web/pdf_rendering_queue.js:197
    forceRendering http://localhost:8888/web/pdf_viewer.js:1849
    promise callback*forceRendering http://localhost:8888/web/pdf_viewer.js:1848
    renderHighestPriority http://localhost:8888/web/pdf_rendering_queue.js:79
    renderView http://localhost:8888/web/pdf_rendering_queue.js:198
    renderView http://localhost:8888/web/pdf_rendering_queue.js:197
    forceRendering http://localhost:8888/web/pdf_viewer.js:1849
    promise callback*forceRendering http://localhost:8888/web/pdf_viewer.js:1848
    renderHighestPriority http://localhost:8888/web/pdf_rendering_queue.js:79
    renderView http://localhost:8888/web/pdf_rendering_queue.js:198
    renderView http://localhost:8888/web/pdf_rendering_queue.js:197
    forceRendering http://localhost:8888/web/pdf_viewer.js:1849
    promise callback*forceRendering http://localhost:8888/web/pdf_viewer.js:1848
    renderHighestPriority http://localhost:8888/web/pdf_rendering_queue.js:79
    update http://localhost:8888/web/pdf_viewer.js:1677
    onScaleChanging http://localhost:8888/web/app.js:2550
    dispatch http://localhost:8888/web/event_utils.js:115
    #setScaleUpdatePages http://localhost:8888/web/pdf_viewer.js:1363
    #setScale http://localhost:8888/web/pdf_viewer.js:1389
    updateScale http://localhost:8888/web/pdf_viewer.js:2263
    updateZoom http://localhost:8888/web/app.js:814
    zoomOut http://localhost:8888/web/app.js:827
    onKeyDown http://localhost:8888/web/app.js:2780
    bindWindowEvents http://localhost:8888/web/app.js:2097
    initialize http://localhost:8888/web/app.js:262
    run http://localhost:8888/web/app.js:704
    webViewerLoad http://localhost:8888/web/viewer.js:294
    <anonymous> http://localhost:8888/web/viewer.js:305
pdf_rendering_queue.js:204:21
```
2025-02-10 09:19:04 +01:00
..
images [Editor] Add an icon for the signature tool and move it before the highlight one 2025-02-06 20:58:59 +01:00
.gitignore Support multiple wasm-files in the development viewer 2025-01-18 09:35:11 +01:00
alt_text_manager.js Remove event listeners with AbortSignal in the AltTextManager class 2024-10-11 12:05:36 +02:00
annotation_editor_layer_builder.css [Editor] Add a new dialog for the signature editor (bug 1945574) 2025-02-05 23:00:38 +01:00
annotation_editor_layer_builder.js [api-major] Change viewer component render-methods to take parameter objects 2025-01-21 23:29:45 +01:00
annotation_editor_params.js Merge pull request #19339 from calixteman/signature_tools 2025-01-30 10:54:56 +01:00
annotation_layer_builder.css Enable editor when double-clicking on stamp annotation 2025-01-14 11:16:59 +01:00
annotation_layer_builder.js Ignore the URLs when checking if inferred links overlap existing LinkAnnotations (PR 19110 follow-up) 2025-02-09 22:06:58 +01:00
app.js Ignore the URLs when checking if inferred links overlap existing LinkAnnotations (PR 19110 follow-up) 2025-02-09 22:06:58 +01:00
app_options.js Enable autolinking in Firefox (bug 1019475) 2025-02-06 17:02:54 +01:00
autolinker.js Enable automatic URL linking 2025-02-05 16:56:54 +01:00
base_tree_viewer.js Limit base-class initialization checks to development and TESTING modes 2024-08-12 12:26:35 +02:00
caret_browsing.js Update the CaretBrowsingMode toolbar-height if the toolbarDensity preference changes (PR 18786 follow-up) 2024-10-01 19:43:16 +02:00
chrome-i18n-allow-access-to-file-urls.json Add translations of "Allow access to file URLs" 2015-08-14 18:59:55 +02:00
chromecom.js Use JSON imports instead of PDFJSDev.json 2024-11-18 16:21:12 +01:00
compressed.tracemonkey-pldi-09.pdf Add Makefile. Move some files around to make building the website easier. 2011-07-05 10:53:57 -07:00
debugger.css Fix the textLayer-opacity when using the FontInspector (PR 17533 follow-up) 2024-01-26 18:31:38 +01:00
debugger.mjs [Debugger] Add some info about substitution font 2023-10-09 12:06:33 +02:00
dialog.css [Editor] Add a new dialog for the signature editor (bug 1945574) 2025-02-05 23:00:38 +01:00
download_manager.js Do not stringify errors when logging them 2024-12-06 14:47:22 +01:00
draw_layer_builder.css [Editor] Add a new base class to allow to add a drawing in the SVG layer. 2024-11-28 15:23:03 +01:00
draw_layer_builder.js [api-major] Change viewer component render-methods to take parameter objects 2025-01-21 23:29:45 +01:00
editor_undo_bar.js [Editor] (WIP) Add a new tool in order to add an handwritten signature to a pdf (bug 1942343) 2025-01-29 21:52:14 +01:00
event_utils.js Add the possibility to dispatch some pdf.js events at the chrome level (bug 1904585) 2024-06-25 21:03:34 +02:00
external_services.js Limit base-class initialization checks to development and TESTING modes 2024-08-12 12:26:35 +02:00
firefox_print_service.js [api-minor] Implement basic support for OptionalContent Usage dicts (issue 5764, bug 1826783) 2024-03-12 13:18:15 +01:00
firefoxcom.js Do not stringify errors when logging them 2024-12-06 14:47:22 +01:00
generic_scripting.js Use a limit, in more places, when splitting strings 2024-02-02 13:10:52 +01:00
genericcom.js [Editor] Corrrectly get the words from the alt-text when reporting the telemetry (bug 1929311) 2024-12-03 19:02:58 +01:00
genericl10n.js [GENERIC viewer] Add Fluent PLATFORM function (PR 19414 follow-up) 2025-02-06 18:59:35 +01:00
grab_to_pan.js Use the stopEvent helper function everywhere possible 2024-11-28 13:25:56 +01:00
interfaces.js Stop sending the unused options parameter to various download-methods in the viewer 2024-08-02 20:46:13 +02:00
l10n.js Do not stringify errors when logging them 2024-12-06 14:47:22 +01:00
message_bar.css Fix unused css variables (follow-up of #18900) 2024-12-04 09:15:01 +01:00
new_alt_text_manager.js [Editor] Corrrectly get the words from the alt-text when reporting the telemetry (bug 1929311) 2024-12-03 19:02:58 +01:00
overlay_manager.js Avoid to remove the active overlay when a cancelled dialog (like the file picker) was called from a dialog 2025-01-30 16:13:48 +01:00
password_prompt.js Use "full" localization ids throughout the code-base 2024-08-31 18:31:31 +02:00
pdf_attachment_viewer.js [api-minor] Improve the FileSpec implementation 2024-05-01 18:02:05 +02:00
pdf_cursor_tools.js Ensure that the CursorTools-buttons are disabled e.g. during editing (PR 15522 follow-up) 2024-09-28 12:29:51 +02:00
pdf_document_properties.js Move the getPage call in PDFDocumentProperties class 2024-12-01 12:25:16 +01:00
pdf_find_bar.js Support toggling the PDFFindBar options with the Enter key (issue 19175) 2024-12-06 17:53:28 +01:00
pdf_find_controller.js Enable automatic URL linking 2025-02-05 16:56:54 +01:00
pdf_find_utils.js [api-minor] Don't normalize the text used in the text layer. 2023-04-17 14:31:23 +02:00
pdf_history.js [CRX] Remove obsolete manifest features 2024-08-25 20:34:03 +02:00
pdf_layer_viewer.js Re-factor how PDFLayerViewer decides if the UI needs to updated on "optionalcontentconfigchanged" events 2024-10-01 13:25:22 +02:00
pdf_link_service.js Allow /XYZ destinations without zoom parameter (issue 18408) 2024-07-18 13:29:32 +02:00
pdf_outline_viewer.js [api-minor] Move the page reference/number caching into the API 2024-04-29 18:54:06 +02:00
pdf_page_view.js Check that the annotationLayer is still active before injecting inferred links (PR 19110 follow-up) 2025-02-10 09:19:04 +01:00
pdf_presentation_mode.js Remove event listeners with signal in web/pdf_presentation_mode.js 2024-04-18 18:41:18 +02:00
pdf_print_service.js Revoke the blob-URLs used during printing in PDFPrintService 2024-08-23 18:39:28 +02:00
pdf_rendering_queue.js Do not stringify errors when logging them 2024-12-06 14:47:22 +01:00
pdf_scripting_manager.component.js Use shorter arrow functions where possible 2024-01-21 10:13:12 +01:00
pdf_scripting_manager.js Do not stringify errors when logging them 2024-12-06 14:47:22 +01:00
pdf_sidebar.js Remove the sidebar resizing event listeners with an AbortController 2024-08-10 12:24:59 +02:00
pdf_single_page_viewer.js Remove the abstract BaseViewer-class 2022-09-08 12:38:17 +02:00
pdf_thumbnail_view.js [Editor] Take into account the device pixel ratio when drawing an added image 2024-09-16 14:48:26 +02:00
pdf_thumbnail_viewer.js Add an option to enable/disable hardware acceleration (bug 1902012) 2024-06-12 18:41:07 +02:00
pdf_viewer.component.js Ensure that GenericL10n works if the locale files cannot be loaded 2024-01-31 14:07:11 +01:00
pdf_viewer.css When zooming replace the css-zoomed canvas by the new one only when rendering is finished 2024-12-05 23:15:04 +01:00
pdf_viewer.js Merge pull request #19110 from ryzokuken/autolink-demo 2025-02-06 16:53:48 +01:00
pdfjs.js Enable automatic URL linking 2025-02-05 16:56:54 +01:00
preferences.js Limit base-class initialization checks to development and TESTING modes 2024-08-12 12:26:35 +02:00
print_utils.js Handle appending consistently in the xfaLayer regardless of rendering intent (PR 17177 follow-up) 2023-10-26 12:05:33 +02:00
secondary_toolbar.js Ensure that the CursorTools-buttons are disabled e.g. during editing (PR 15522 follow-up) 2024-09-28 12:29:51 +02:00
signature_manager.css Fix --save-warning-color CSS variable typo (PR 19414 follow-up) 2025-02-06 19:06:04 +01:00
signature_manager.js [Editor] Add the ability to print and save some newly added signatures (bug 1946795) 2025-02-07 23:07:27 +01:00
struct_tree_layer_builder.js [api-major] Change viewer component render-methods to take parameter objects 2025-01-21 23:29:45 +01:00
stubs-geckoview.js [Editor] Add a new dialog for the signature editor (bug 1945574) 2025-02-05 23:00:38 +01:00
text_accessibility.js [Editor] Add the parent tag id (if any) to the serialized editors (bug 1845087) 2023-09-07 18:22:33 +02:00
text_highlighter.js Fix left offset when scrolling to search result 2024-12-16 16:04:13 +01:00
text_layer_builder.css Make tagged images visible for screen readers (bug 1708040) 2024-09-05 17:59:42 +02:00
text_layer_builder.js [api-major] Change viewer component render-methods to take parameter objects 2025-01-21 23:29:45 +01:00
toggle_button.css Remove unused CSS variables 2025-01-07 10:29:23 +01:00
toolbar-geckoview.js [GeckoView] Remove the open-in-app button (bug 1832519) 2024-03-04 19:32:12 +01:00
toolbar.js Merge pull request #19339 from calixteman/signature_tools 2025-01-30 10:54:56 +01:00
ui_utils.js [Editor] Take into account the device pixel ratio when drawing an added image 2024-09-16 14:48:26 +02:00
view_history.js Add a bit more validation in the ViewHistory constructor 2020-03-21 13:55:06 +01:00
viewer-geckoview.css [GV] Increase the height (48px) of the toolbar in order to fit the a11y recommendations (bug 1838602) 2024-10-02 19:17:40 +02:00
viewer-geckoview.html [Editor] Add a new dialog for the signature editor (bug 1945574) 2025-02-05 23:00:38 +01:00
viewer-geckoview.js Upgrade eslint-plugin-perfectionist to version 4.2.0 2024-12-07 13:44:48 +01:00
viewer-snippet-chrome-extension.html [api-minor] Move to Fluent for the localization (bug 1858715) 2023-10-19 11:20:41 +02:00
viewer-snippet-chrome-overlays.html Convert the existing overlays to use <dialog> elements (issue 14698) 2022-03-28 11:36:29 +02:00
viewer-snippet-firefox-extension.html [api-major] Output JavaScript modules in the builds (issue 10317) 2023-10-07 09:31:08 +02:00
viewer-snippet.html [api-minor] Move to Fluent for the localization (bug 1858715) 2023-10-19 11:20:41 +02:00
viewer.css [Editor] (WIP) Add a new tool in order to add an handwritten signature to a pdf (bug 1942343) 2025-01-29 21:52:14 +01:00
viewer.html [Editor] Add an icon for the signature tool and move it before the highlight one 2025-02-06 20:58:59 +01:00
viewer.js [Editor] Add a new dialog for the signature editor (bug 1945574) 2025-02-05 23:00:38 +01:00
xfa_layer_builder.css Remove unnecessary alpha-value from CSS rgb colors 2023-10-06 09:50:03 +02:00
xfa_layer_builder.js [api-major] Change viewer component render-methods to take parameter objects 2025-01-21 23:29:45 +01:00