mirror of
https://github.com/mozilla/pdf.js.git
synced 2025-04-20 07:08:08 +02:00
cdea75dc39
When the user edits the URL and changes the reference fragment (hash), PDF.js intercepts this action, and saves the then-current history state in the previous history entry. This is implemented by navigating back, editing the history and navigating forward again. The current logic has a flaw: It assumes that calling history.back() and history.forward() immediately updates the history state. This is however not guaranteed by the web standards, which states that calling e.g. history.back "must traverse the history by a delta -1", which means that the browser must QUEUE a task to traverse the session history, per spec: http://w3.org/TR/2011/WD-html5-20110113/history.html#dom-history-back https://html.spec.whatwg.org/multipage/browsers.html#dom-history-back Firefox and Internet Explorer deviate from the standards by immediately changing the history state instead of queuing the navigation. WebKit derived browsers (Chrome, Opera, Safari) and Opera presto do not. The user-visible consequence of strictly adhering to the standards in PDF.js can be shown as follows: 1. Edit the URL. 2. Append #page=2 for example. 3. Press Enter. -> Presto and WebKit: PDF.js reverts to the previous URL. -> Gecko and Trident: PDF.js keeps the new URL, as expected. To fix the issue, modification of the previous history item happens in a few asynchronous steps, guided by the popstate event to detect when the history navigation request has been committed. -- Some more implementation notes: I have removed the preventDefault and stopPropagation calls, because popstate is not cancelable, and window is already the last target of the event propagation. The previous allowHashChange logic was hard to follow, because it did not explain that hashchange will be called twice; once during the popstate handler for history.back() (which will reset allowHashChange), and again for history.forward() (where allowHashChange will be false). The purpose of allowHashChange is now more explicit, by incorporating the logic in the replacePreviousHistoryState helper function. |
||
|---|---|---|
| .. | ||
| images | ||
| .gitignore | ||
| annotations_layer_builder.js | ||
| chromecom.js | ||
| compatibility.js | ||
| compressed.tracemonkey-pldi-09.pdf | ||
| debugger.js | ||
| default_preferences.js | ||
| download_manager.js | ||
| firefoxcom.js | ||
| grab_to_pan.js | ||
| hand_tool.js | ||
| interfaces.js | ||
| mozPrintCallback_polyfill.js | ||
| overlay_manager.js | ||
| password_prompt.js | ||
| pdf_attachment_view.js | ||
| pdf_document_properties.js | ||
| pdf_find_bar.js | ||
| pdf_find_controller.js | ||
| pdf_history.js | ||
| pdf_link_service.js | ||
| pdf_outline_view.js | ||
| pdf_page_view.js | ||
| pdf_presentation_mode.js | ||
| pdf_rendering_queue.js | ||
| pdf_thumbnail_view.js | ||
| pdf_thumbnail_viewer.js | ||
| pdf_viewer.component.js | ||
| pdf_viewer.css | ||
| pdf_viewer.js | ||
| preferences.js | ||
| secondary_toolbar.js | ||
| text_layer_builder.css | ||
| text_layer_builder.js | ||
| ui_utils.js | ||
| view_history.js | ||
| viewer-snippet-chrome-extension.html | ||
| viewer-snippet-firefox-extension.html | ||
| viewer-snippet-minified.html | ||
| viewer-snippet-mozPrintCallback-polyfill.html | ||
| viewer-snippet.html | ||
| viewer.css | ||
| viewer.html | ||
| viewer.js | ||