mirror of
https://github.com/mozilla/pdf.js.git
synced 2025-04-20 07:08:08 +02:00
8836593b9e
Given that the regular expression has already become more complex (after the initial patch adding it), it seems to me that it probably cannot hurt to add a global cache to reduce unnecessary re-parsing. Obviously the `Glyph`-instances are being cached *per* font, however in most documents multiple fonts are being used and in practice there's very often a fair amount of overlap between the /ToUnicode-data in different fonts[1]. Consider for example loading and rendering the entire `tracemonkey.pdf` document (from the test-suite), which isn't a particularily large document. In that case the `getCharUnicodeCategory` function is being called a total of `601` times, however there's only `106` *unique* unicode-chars being checked. *Please note:* In practice I suppose that this won't have a *huge* effect on overall performance, however given the relative simplicity of this patch I figured that it'd not hurt to submit it for review. --- [1] Consider e.g. how there's usually different fonts used for regular, bold, respectively italic text. |
||
|---|---|---|
| .. | ||
| core | ||
| display | ||
| images | ||
| scripting_api | ||
| shared | ||
| doc_helper.js | ||
| interfaces.js | ||
| license_header.js | ||
| license_header_libre.js | ||
| pdf.image_decoders.js | ||
| pdf.js | ||
| pdf.sandbox.external.js | ||
| pdf.sandbox.js | ||
| pdf.scripting.js | ||
| pdf.worker.entry.js | ||
| pdf.worker.js | ||
| worker_loader.js | ||