mirror of
https://github.com/mozilla/pdf.js.git
synced 2025-04-26 10:08:06 +02:00
2e9cd3ea64
Originally, I was just going to change this code to use `Ref_toString` in a couple more places. When I started reading the code, I figured that it wouldn't hurt to clean up a couple of comments. While doing this, I noticed that the logic for the (rare) `isDict(fontRef)` case could do with a few improvements. There should be no functional changes with this patch, but given the added reference checks, we will now avoid bogus `Ref`s when resolving font aliases. In practice, as issue 7403 shows, the current code can break certain PDF files even if it's very rare. Note that the only thing that this patch will change, is the `font.loadedName` in the case where a `fontRef` is a reference *and* the font doesn't have a descriptor. Previously for `fontRef = Ref(4, 0)` we'd get `font.loadedName = 'g_d0_f4_0'`, and with this patch `font.loadedName = g_d0_f4R`, which is actually one character shorted in most cases. (Given that `Ref_toString` contains an optimization for the `gen === 0` case, which is by far the most common `gen` value.) In the already existing fallback case, where the `fontName` is used to when creating the `font.loadedName`, we allow any alphanumeric character. Hence I don't see how (as mentioned above) e.g. `font.loadedName = g_d0_f4R` would be an issue here. |
||
|---|---|---|
| .. | ||
| annotation.js | ||
| arithmetic_decoder.js | ||
| bidi.js | ||
| cff_parser.js | ||
| charsets.js | ||
| chunked_stream.js | ||
| cmap.js | ||
| colorspace.js | ||
| crypto.js | ||
| document.js | ||
| encodings.js | ||
| evaluator.js | ||
| font_renderer.js | ||
| fonts.js | ||
| function.js | ||
| glyphlist.js | ||
| image.js | ||
| jbig2.js | ||
| jpg.js | ||
| jpx.js | ||
| metrics.js | ||
| murmurhash3.js | ||
| network.js | ||
| obj.js | ||
| parser.js | ||
| pattern.js | ||
| pdf_manager.js | ||
| primitives.js | ||
| ps_parser.js | ||
| standard_fonts.js | ||
| stream.js | ||
| type1_parser.js | ||
| unicode.js | ||
| worker.js | ||