mirror of
https://github.com/mozilla/pdf.js.git
synced 2025-04-20 07:08:08 +02:00
2643570364
*Please note:* This removes top level await from the GENERIC builds of the PDF.js library. Despite top level await being supported in all modern browsers/environments, note [the MDN compatibility data](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/await#browser_compatibility), it seems that many frameworks and build-tools unfortunately have trouble with it. Hence, in order to reduce the influx of support requests regarding top level await it thus seems that we'll have to try and fix this. Given that top level await is only needed for Node.js environments, to load packages/polyfills, we re-factor things to limit the asynchronicity to that environment. The "best" solution, with the least likelihood of causing future problems, would probably be to await the load of Node.js packages/polyfills e.g. at the top of the `getDocument`-function. Unfortunately that doesn't work though, since that's a *synchronous* function that we cannot change without breaking "the world". Hence we instead await the load of Node.js packages/polyfills together with the `PDFWorker` initialization, since that's the *first point* of asynchronicity during initialization/loading of a PDF document. The reason that this works is that the Node.js packages/polyfills are only needed during fetching of the PDF document respectively during rendering, neither of which can happen *until* the worker has been initialized. Hopefully this won't cause any future problems, since looking at the history of the PDF.js project I don't believe that we've (thus far) ever needed a Node.js dependency at an earlier point. This new pattern for accessing Node.js packages/polyfills will also require some care during development *and* importantly reviewing, to ensure that no new top level await is added in the main code-base. |
||
|---|---|---|
| .. | ||
| chromium | ||
| font | ||
| fuzz | ||
| images | ||
| integration | ||
| pdfs | ||
| resources | ||
| stats | ||
| types | ||
| unit | ||
| .eslintrc | ||
| .gitignore | ||
| add_test.mjs | ||
| annotation_layer_builder_overrides.css | ||
| downloadutils.mjs | ||
| draw_layer_test.css | ||
| driver.js | ||
| integration-boot.mjs | ||
| test.mjs | ||
| test_manifest.json | ||
| test_slave.html | ||
| testutils.mjs | ||
| text_layer_test.css | ||
| webserver.mjs | ||
| xfa_layer_builder_overrides.css | ||