mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-20 15:18:08 +02:00
Code Activity

Merge pull request #15782 from calixteman/15780

Browse source 
[api-minor][Editor] Don't use the editor parent which can be null.
This commit is contained in:
calixteman 2022-12-08 14:27:42 +01:00 • committed by GitHub
commit fe3df4dcb4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 270 additions and 126 deletions
Download patch file Download diff file Expand all files Collapse all files

4
web/default_factory.js
View file

@ -111,9 +111,7 @@ class DefaultAnnotationEditorLayerFactory {
* @property {HTMLDivElement} pageDiv
* @property {PDFPageProxy} pdfPage
* @property {IL10n} l10n
* @property {AnnotationStorage} [annotationStorage] - Storage for annotation
* @property {TextAccessibilityManager} [accessibilityManager]
* data in forms.
*/
/**
@ -126,7 +124,6 @@ class DefaultAnnotationEditorLayerFactory {
pdfPage,
accessibilityManager = null,
l10n,
annotationStorage = null,
}) {
return new AnnotationEditorLayerBuilder({
uiManager,
@ -134,7 +131,6 @@ class DefaultAnnotationEditorLayerFactory {
pdfPage,
accessibilityManager,
l10n,
annotationStorage,
});
}
}

3
web/interfaces.js
View file

@ -237,9 +237,7 @@ class IPDFAnnotationEditorLayerFactory {
* @property {HTMLDivElement} pageDiv
* @property {PDFPageProxy} pdfPage
* @property {IL10n} l10n
* @property {AnnotationStorage} [annotationStorage] - Storage for annotation
* @property {TextAccessibilityManager} [accessibilityManager]
* data in forms.
*/
/**
@ -251,7 +249,6 @@ class IPDFAnnotationEditorLayerFactory {
pageDiv,
pdfPage,
l10n,
annotationStorage = null,
accessibilityManager,
}) {}
}

7
web/pdf_viewer.js
View file

@ -730,7 +730,8 @@ class PDFViewer {
} else if (isValidAnnotationEditorMode(mode)) {
this.#annotationEditorUIManager = new AnnotationEditorUIManager(
this.container,
this.eventBus
this.eventBus,
this.pdfDocument?.annotationStorage
);
if (mode !== AnnotationEditorType.NONE) {
this.#annotationEditorUIManager.updateMode(mode);
@ -1741,9 +1742,7 @@ class PDFViewer {
* @property {HTMLDivElement} pageDiv
* @property {PDFPageProxy} pdfPage
* @property {IL10n} l10n
* @property {AnnotationStorage} [annotationStorage] - Storage for annotation
* @property {TextAccessibilityManager} [accessibilityManager]
* data in forms.
*/
/**
@ -1756,13 +1755,11 @@ class PDFViewer {
pdfPage,
accessibilityManager = null,
l10n,
annotationStorage = this.pdfDocument?.annotationStorage,
}) {
return new AnnotationEditorLayerBuilder({
uiManager,
pageDiv,
pdfPage,
annotationStorage,
accessibilityManager,
l10n,
});