mirror of
https://github.com/mozilla/pdf.js.git
synced 2025-04-19 22:58:07 +02:00
Create the borderStyle
of inferred links lazily (PR 19110 follow-up)
Given that most inferred links will overlap existing LinkAnnotations, creating a lot of unused `borderStyle` objects seem unnecessary. Hence we can move that into the `AnnotationLayer.prototype.addLinkAnnotations` method instead, which also allows us to slightly reduce the API-surface.
This commit is contained in:
parent
e608daed9f
commit
fba5f3c237
5 changed files with 24 additions and 21 deletions
|
@ -13,12 +13,7 @@
|
|||
* limitations under the License.
|
||||
*/
|
||||
|
||||
import {
|
||||
AnnotationBorderStyleType,
|
||||
AnnotationType,
|
||||
createValidAbsoluteUrl,
|
||||
Util,
|
||||
} from "pdfjs-lib";
|
||||
import { AnnotationType, createValidAbsoluteUrl, Util } from "pdfjs-lib";
|
||||
import { getOriginalIndex, normalize } from "./pdf_find_controller.js";
|
||||
|
||||
function DOMRectToPDF({ width, height, left, top }, pdfPageView) {
|
||||
|
@ -89,15 +84,9 @@ function createLinkAnnotation({ url, index, length }, pdfPageView, id) {
|
|||
annotationType: AnnotationType.LINK,
|
||||
rotation: 0,
|
||||
...calculateLinkPosition(range, pdfPageView),
|
||||
// This is just the default for AnnotationBorderStyle.
|
||||
borderStyle: {
|
||||
width: 1,
|
||||
rawWidth: 1,
|
||||
style: AnnotationBorderStyleType.SOLID,
|
||||
dashArray: [3],
|
||||
horizontalCornerRadius: 0,
|
||||
verticalCornerRadius: 0,
|
||||
},
|
||||
// Populated in the annotationLayer to avoid unnecessary object creation,
|
||||
// since most inferred links overlap existing LinkAnnotations:
|
||||
borderStyle: null,
|
||||
};
|
||||
}
|
||||
|
||||
|
|
|
@ -15,7 +15,6 @@
|
|||
|
||||
const {
|
||||
AbortException,
|
||||
AnnotationBorderStyleType,
|
||||
AnnotationEditorLayer,
|
||||
AnnotationEditorParamsType,
|
||||
AnnotationEditorType,
|
||||
|
@ -65,7 +64,6 @@ const {
|
|||
|
||||
export {
|
||||
AbortException,
|
||||
AnnotationBorderStyleType,
|
||||
AnnotationEditorLayer,
|
||||
AnnotationEditorParamsType,
|
||||
AnnotationEditorType,
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue