mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-20 23:28:06 +02:00
Code Activity

Remove the remaining usages of new {Name,Cmd} in favor of {Name,Cmd}.get

Browse source 
Using `new {Name,Cmd}` should be avoided, since it creates a new object on *every* call, whereas `{Name,Cmd}.get` uses caches to only create *one* object regardless of how many times they are called.

Most of these are found in the unit-tests, where increased memory usage probably doesn't matter very much. But it still seems good to get rid of those cases, since no part of the codebase ought to advertise that usage.

Given the small size of the patch, I'm also tweaking a few comments and class names.
This commit is contained in:
Jonas Jenwald 2016-04-08 12:14:05 +02:00
parent 1c253e6e1d
commit f59c3a0644
3 changed files with 11 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/unit/cmap_spec.js
View file

@ -160,7 +160,7 @@ describe('cmap', function() {
});
});
it('loads built in cmap', function(done) {
var cmapPromise = CMapFactory.create(new Name('Adobe-Japan1-1'),
var cmapPromise = CMapFactory.create(Name.get('Adobe-Japan1-1'),
{ url: cMapUrl, packed: cMapPacked }, null);
cmapPromise.then(function (cmap) {
expect(cmap instanceof CMap).toEqual(true);
@ -174,7 +174,7 @@ describe('cmap', function() {
});
});
it('loads built in identity cmap', function(done) {
var cmapPromise = CMapFactory.create(new Name('Identity-H'),
var cmapPromise = CMapFactory.create(Name.get('Identity-H'),
{ url: cMapUrl, packed: cMapPacked }, null);
cmapPromise.then(function (cmap) {
expect(cmap instanceof IdentityCMap).toEqual(true);

2
test/unit/primitives_spec.js
View file

@ -16,7 +16,7 @@ describe('primitives', function() {
describe('Cmd', function() {
it('should retain the given cmd name', function() {
var givenCmd = 'BT';
var cmd = new Cmd(givenCmd);
var cmd = Cmd.get(givenCmd);
expect(cmd.cmd).toEqual(givenCmd);
});