From f2a132f826a9b739b19bfb14efb86dfc02531d86 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Tue, 1 Oct 2024 17:17:40 +0200 Subject: [PATCH] Use the "correct" toolbar container element in `getViewerConfiguration` (PR 18385 follow-up) With the changes made in PR 18385 the `toolbarViewer` element is now shorter than before, since the padding is applied on its `toolbarContainer` parent-element instead. This causes two separate regressions: - Clicking at the very top/bottom of the toolbar no longer closes the secondaryToolbar like previously. - The `CaretBrowsingMode`-constructor no longer computes the toolbar-height correctly. Given how/where the `container`-property is being used these changes *should* thus be safe. --- web/viewer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/viewer.js b/web/viewer.js index 1115af56e..a60142ae5 100644 --- a/web/viewer.js +++ b/web/viewer.js @@ -41,7 +41,7 @@ function getViewerConfiguration() { mainContainer: document.getElementById("viewerContainer"), viewerContainer: document.getElementById("viewer"), toolbar: { - container: document.getElementById("toolbarViewer"), + container: document.getElementById("toolbarContainer"), numPages: document.getElementById("numPages"), pageNumber: document.getElementById("pageNumber"), scaleSelect: document.getElementById("scaleSelect"),