mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 22:58:07 +02:00
Code Activity

Make the onError callback required in NetworkManager

Browse source 
This helps ensure that loading errors are always handled correctly, and note that both `PDFNetworkStreamFullRequestReader` and `PDFNetworkStreamRangeRequestReader` already provided such a callback.
This commit is contained in:
Jonas Jenwald 2024-12-01 11:36:18 +01:00
parent 2661d0623b
commit eff8ede33e
1 changed files with 8 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/display/network.js
View file

@ -85,11 +85,10 @@ class NetworkManager {
}
xhr.responseType = "arraybuffer";
if (args.onError) {
xhr.onerror = function (evt) {
args.onError(xhr.status);
};
}
assert(args.onError, "Expected `onError` callback to be provided.");
xhr.onerror = () => {
args.onError(xhr.status);
};
xhr.onreadystatechange = this.onStateChange.bind(this, xhrId);
xhr.onprogress = this.onProgress.bind(this, xhrId);
@ -137,7 +136,7 @@ class NetworkManager {
// Success status == 0 can be on ftp, file and other protocols.
if (xhr.status === 0 && this.isHttp) {
pendingRequest.onError?.(xhr.status);
pendingRequest.onError(xhr.status);
return;
}
const xhrStatus = xhr.status || OK_RESPONSE;
@ -153,7 +152,7 @@ class NetworkManager {
!ok_response_on_range_request &&
xhrStatus !== pendingRequest.expectedStatus
) {
pendingRequest.onError?.(xhr.status);
pendingRequest.onError(xhr.status);
return;
}
@ -168,7 +167,7 @@ class NetworkManager {
});
} else {
warn(`Missing or invalid "Content-Range" header.`);
pendingRequest.onError?.(0);
pendingRequest.onError(0);
}
} else if (chunk) {
pendingRequest.onDone({
@ -176,7 +175,7 @@ class NetworkManager {
chunk,
});
} else {
pendingRequest.onError?.(xhr.status);
pendingRequest.onError(xhr.status);
}
}