mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 22:58:07 +02:00
Code Activity

[Editor] Slightly simplify the serialization of an highlight annotation

Browse source 
We were computing width and height of the annotation before serializing
which is useless because the rect already contains this information.
This commit is contained in:
Calixte Denizet 2024-01-15 18:10:28 +01:00
parent 7769018316
commit ee72b32dc2
2 changed files with 16 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/display/editor/highlight.js
View file

@ -384,13 +384,7 @@ class HighlightEditor extends AnnotationEditor {
}
#serializeOutlines(rect) {
const [pageWidth, pageHeight] = this.pageDimensions;
return this.#highlightOutlines.serialize(
rect[0],
rect[1],
this.width * pageWidth,
this.height * pageHeight
);
return this.#highlightOutlines.serialize(rect, 0);
}
/** @inheritdoc */

18
src/display/editor/outliner.js
View file

@ -267,6 +267,10 @@ class Outline {
get box() {
throw new Error("Abstract getter `box` must be implemented.");
}
serialize(_bbox, _rotation) {
throw new Error("Abstract method `serialize` must be implemented.");
}
}
class HighlightOutline extends Outline {
@ -301,13 +305,21 @@ class HighlightOutline extends Outline {
return buffer.join(" ");
}
serialize(x, y, width, height) {
/**
* Serialize the outlines into the PDF page coordinate system.
* @param {Array<number>} _bbox - the bounding box of the annotation.
* @param {number} _rotation - the rotation of the annotation.
* @returns {Array<Array<number>>}
*/
serialize([blX, blY, trX, trY], _rotation) {
const outlines = [];
const width = trX - blX;
const height = trY - blY;
for (const outline of this.#outlines) {
const points = new Array(outline.length);
for (let i = 0; i < outline.length; i += 2) {
points[i] = x + outline[i] * width;
points[i + 1] = y + (1 - outline[i + 1]) * height;
points[i] = blX + outline[i] * width;
points[i + 1] = trY - outline[i + 1] * height;
}
outlines.push(points);
}