mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 22:58:07 +02:00
Code Activity

Remove the enableScripting option from the PDFPageView constructor

Browse source 
Scripting, as implemented, requires access to a complete document/viewer in order to work. Hence it doesn't really make sense to keep the `enableScripting`-option on `PDFPageView`-instances.[1]

---
[1] Note that there's the `PDFSinglePageViewer`, which can be used in cases where you want access to all features/functionality of the viewer but only display *one* page at a time.
This commit is contained in:
Jonas Jenwald 2021-04-09 14:20:47 +02:00
parent 6429ccc002
commit ec9e29807a
2 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

5
web/base_viewer.js
View file

@ -552,7 +552,6 @@ class BaseViewer {
useOnlyCssZoom: this.useOnlyCssZoom,
maxCanvasPixels: this.maxCanvasPixels,
l10n: this.l10n,
enableScripting: this.enableScripting,
});
this._pages.push(pageView);
}
@ -1296,7 +1295,7 @@ class BaseViewer {
imageResourcesPath = "",
renderInteractiveForms = false,
l10n = NullL10n,
enableScripting = false,
enableScripting = null,
hasJSActionsPromise = null,
mouseState = null
) {
@ -1310,7 +1309,7 @@ class BaseViewer {
linkService: this.linkService,
downloadManager: this.downloadManager,
l10n,
enableScripting,
enableScripting: enableScripting ?? this.enableScripting,
hasJSActionsPromise:
hasJSActionsPromise || this.pdfDocument?.hasJSActions(),
mouseState: mouseState || this._scriptingManager?.mouseState,

5
web/pdf_page_view.js
View file

@ -62,8 +62,6 @@ import { viewerCompatibilityParams } from "./viewer_compatibility.js";
* total pixels, i.e. width * height. Use -1 for no limit. The default value
* is 4096 * 4096 (16 mega-pixels).
* @property {IL10n} l10n - Localization service.
* @property {boolean} [enableScripting] - Enable embedded script execution.
* The default value is `false`.
*/
const MAX_CANVAS_PIXELS = viewerCompatibilityParams.maxCanvasPixels || 16777216;
@ -107,7 +105,6 @@ class PDFPageView {
this.renderer = options.renderer || RendererType.CANVAS;
this.enableWebGL = options.enableWebGL || false;
this.l10n = options.l10n || NullL10n;
this.enableScripting = options.enableScripting === true;
this.paintTask = null;
this.paintedViewportMap = new WeakMap();
@ -584,7 +581,7 @@ class PDFPageView {
this.imageResourcesPath,
this.renderInteractiveForms,
this.l10n,
this.enableScripting,
/* enableScripting */ null,
/* hasJSActionsPromise = */ null,
/* mouseState = */ null
);