mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-26 10:08:06 +02:00
Code Activity

Ensure that Cmd/Name is only initialized with string arguments

Browse source 
Trying to use a non-string argument in either a `Cmd` or a `Name` is not intended, and would basically be an implementation error. Hence we can add a non-PRODUCTION check to enforce this, similar to the existing one used e.g. in the `Dict.set` method.
This commit is contained in:
Jonas Jenwald 2022-02-23 22:39:12 +01:00
parent 2bb96a708c
commit ec87995050
3 changed files with 27 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/core/cmap.js
View file

@ -901,7 +901,7 @@ const CMapFactory = (function CMapFactoryClosure() {
function parseCMapName(cMap, lexer) {
const obj = lexer.getObj();
if (obj instanceof Name && isString(obj.name)) {
if (obj instanceof Name) {
cMap.name = obj.name;
}
}

14
src/core/primitives.js
View file

@ -24,6 +24,13 @@ const Name = (function NameClosure() {
// eslint-disable-next-line no-shadow
class Name {
constructor(name) {
if (
(typeof PDFJSDev === "undefined" ||
PDFJSDev.test("!PRODUCTION || TESTING")) &&
typeof name !== "string"
) {
unreachable('Name: The "name" must be a string.');
}
this.name = name;
}
@ -47,6 +54,13 @@ const Cmd = (function CmdClosure() {
// eslint-disable-next-line no-shadow
class Cmd {
constructor(cmd) {
if (
(typeof PDFJSDev === "undefined" ||
PDFJSDev.test("!PRODUCTION || TESTING")) &&
typeof cmd !== "string"
) {
unreachable('Cmd: The "cmd" must be a string.');
}
this.cmd = cmd;
}