mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-18 14:18:23 +02:00
Code Activity

Remove Array.prototype.reduce usage from the unit-tests

Browse source 
Using `Array.prototype.reduce` often leads to less readable code, and in these cases we can replace it with other Array-methods instead.
This commit is contained in:
Jonas Jenwald 2025-04-06 12:12:37 +02:00
parent 6cc37c8415
commit ec5b5184d3
1 changed files with 8 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

19
test/unit/ui_utils_spec.js
View file

@ -234,9 +234,8 @@ describe("ui_utils", function () {
let lineTop = 0,
id = 0;
for (const line of lines) {
const lineHeight = line.reduce(function (maxHeight, pair) {
return Math.max(maxHeight, pair[1]);
}, 0);
const heights = line.map(pair => pair[1]);
const lineHeight = Math.max(...heights);
let offsetLeft = -BORDER_WIDTH;
for (const [clientWidth, clientHeight] of line) {
const offsetTop =
@ -320,14 +319,12 @@ describe("ui_utils", function () {
// test to the slower implementation above, for a range of scroll viewport
// sizes and positions.
function scrollOverDocument(pages, horizontal = false, rtl = false) {
const size = pages.reduce(function (max, { div }) {
return Math.max(
max,
horizontal
? Math.abs(div.offsetLeft + div.clientLeft + div.clientWidth)
: div.offsetTop + div.clientTop + div.clientHeight
);
}, 0);
const sizes = pages.map(({ div }) =>
horizontal
? Math.abs(div.offsetLeft + div.clientLeft + div.clientWidth)
: div.offsetTop + div.clientTop + div.clientHeight
);
const size = Math.max(...sizes);
// The numbers (7 and 5) are mostly arbitrary, not magic: increase them to
// make scrollOverDocument tests faster, decrease them to make the tests
// more scrupulous, and keep them coprime to reduce the chance of missing