mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-22 16:18:08 +02:00
Code Activity

Prevent browser console errors during testing

Browse source 
The `Driver._cleanup` method is removing all stylesheets between test runs, which causes "TypeError: styleElement.parentNode is null" console errors in `FontLoader.clear`.

As can also be seen during various tests, some of the changes I made in PR 7972 unfortunately causes console errors.
It seems that I didn't test this properly, since it *should* have been obvious to me that while tests are triggered using Node.js, the files in question are run within the *browser*.
My apologies for not testing this thoroughly, and for causing unnecessary churn in the code!
This commit is contained in:
Jonas Jenwald 2017-02-05 13:23:42 +01:00
parent cae8d97c4c
commit e416032b38
4 changed files with 9 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/display/font_loader.js
View file

@ -61,7 +61,10 @@ FontLoader.prototype = {
clear: function fontLoaderClear() {
var styleElement = this.styleElement;
if (styleElement) {
styleElement.parentNode.removeChild(styleElement);
if (styleElement.parentNode) {
// Prevent "TypeError: styleElement.parentNode is null" during testing.
styleElement.parentNode.removeChild(styleElement);
}
styleElement = this.styleElement = null;
}
if (typeof PDFJSDev === 'undefined' || !PDFJSDev.test('MOZCENTRAL')) {