mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-21 15:48:06 +02:00
Code Activity

[api-minor] Move the ReadableStream polyfill to the global scope

Browse source 
Note that most (reasonably) modern browsers have supported this for a while now, see https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream#Browser_compatibility

By moving the polyfill into `src/shared/compatibility.js` we can thus get rid of the need to manually export/import `ReadableStream` and simply use it directly instead.

The only change here which *could* possibly lead to a difference in behavior is in the `isFetchSupported` function. Previously we attempted to check for the existence of a global `ReadableStream` implementation, which could now pass (assuming obviously that the preceding checks also succeeded).
However I'm not sure if that's a problem, since the previous check only confirmed the existence of a native `ReadableStream` implementation and not that it actually worked correctly. Finally it *could* just as well have been a globally registered polyfill from an application embedding the PDF.js library.
This commit is contained in:
Jonas Jenwald 2019-10-14 13:19:41 +02:00
parent af4ba75f68
commit e24050fa13
8 changed files with 32 additions and 68 deletions
Download patch file Download diff file Expand all files Collapse all files

3
test/unit/util_spec.js
View file

@ -16,8 +16,7 @@
import {
bytesToString, createPromiseCapability, createValidAbsoluteUrl, isArrayBuffer,
isBool, isEmptyObj, isNum, isSameOrigin, isSpace, isString, log2,
ReadableStream, removeNullCharacters, string32, stringToBytes,
stringToPDFString
removeNullCharacters, string32, stringToBytes, stringToPDFString
} from '../../src/shared/util';
describe('util', function() {