mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-21 23:58:07 +02:00
Code Activity

Re-factor ColorSpace.parse to take a parameter object, rather than a bunch of (randomly) ordered parameters

Browse source 
Given the number of existing parameters, this will avoid needlessly unwieldy call-sites especially with upcoming changes in later patches.
This commit is contained in:
Jonas Jenwald 2020-06-17 18:17:43 +02:00
parent ac4a5c3ace
commit e22bc483a5
5 changed files with 124 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

99
test/unit/colorspace_spec.js
View file

@ -55,12 +55,17 @@ describe("colorspace", function () {
data: new Dict(),
},
]);
const res = new Dict();
const resources = new Dict();
const pdfFunctionFactory = new PDFFunctionFactory({
xref,
});
const colorSpace = ColorSpace.parse(cs, xref, res, pdfFunctionFactory);
const colorSpace = ColorSpace.parse({
cs,
xref,
resources,
pdfFunctionFactory,
});
const testSrc = new Uint8Array([27, 125, 250, 131]);
const testDest = new Uint8ClampedArray(4 * 4 * 3);
@ -100,12 +105,17 @@ describe("colorspace", function () {
data: Name.get("DeviceGray"),
},
]);
const res = new Dict();
const resources = new Dict();
const pdfFunctionFactory = new PDFFunctionFactory({
xref,
});
const colorSpace = ColorSpace.parse(cs, xref, res, pdfFunctionFactory);
const colorSpace = ColorSpace.parse({
cs,
xref,
resources,
pdfFunctionFactory,
});
const testSrc = new Uint8Array([27, 125, 250, 131]);
const testDest = new Uint8ClampedArray(3 * 3 * 3);
@ -141,12 +151,17 @@ describe("colorspace", function () {
data: new Dict(),
},
]);
const res = new Dict();
const resources = new Dict();
const pdfFunctionFactory = new PDFFunctionFactory({
xref,
});
const colorSpace = ColorSpace.parse(cs, xref, res, pdfFunctionFactory);
const colorSpace = ColorSpace.parse({
cs,
xref,
resources,
pdfFunctionFactory,
});
// prettier-ignore
const testSrc = new Uint8Array([
@ -192,12 +207,17 @@ describe("colorspace", function () {
data: Name.get("DeviceRGB"),
},
]);
const res = new Dict();
const resources = new Dict();
const pdfFunctionFactory = new PDFFunctionFactory({
xref,
});
const colorSpace = ColorSpace.parse(cs, xref, res, pdfFunctionFactory);
const colorSpace = ColorSpace.parse({
cs,
xref,
resources,
pdfFunctionFactory,
});
// prettier-ignore
const testSrc = new Uint8Array([
@ -239,12 +259,17 @@ describe("colorspace", function () {
data: new Dict(),
},
]);
const res = new Dict();
const resources = new Dict();
const pdfFunctionFactory = new PDFFunctionFactory({
xref,
});
const colorSpace = ColorSpace.parse(cs, xref, res, pdfFunctionFactory);
const colorSpace = ColorSpace.parse({
cs,
xref,
resources,
pdfFunctionFactory,
});
// prettier-ignore
const testSrc = new Uint8Array([
@ -290,12 +315,17 @@ describe("colorspace", function () {
data: Name.get("DeviceCMYK"),
},
]);
const res = new Dict();
const resources = new Dict();
const pdfFunctionFactory = new PDFFunctionFactory({
xref,
});
const colorSpace = ColorSpace.parse(cs, xref, res, pdfFunctionFactory);
const colorSpace = ColorSpace.parse({
cs,
xref,
resources,
pdfFunctionFactory,
});
// prettier-ignore
const testSrc = new Uint8Array([
@ -342,12 +372,17 @@ describe("colorspace", function () {
data: new Dict(),
},
]);
const res = new Dict();
const resources = new Dict();
const pdfFunctionFactory = new PDFFunctionFactory({
xref,
});
const colorSpace = ColorSpace.parse(cs, xref, res, pdfFunctionFactory);
const colorSpace = ColorSpace.parse({
cs,
xref,
resources,
pdfFunctionFactory,
});
const testSrc = new Uint8Array([27, 125, 250, 131]);
const testDest = new Uint8ClampedArray(4 * 4 * 3);
@ -396,12 +431,17 @@ describe("colorspace", function () {
data: new Dict(),
},
]);
const res = new Dict();
const resources = new Dict();
const pdfFunctionFactory = new PDFFunctionFactory({
xref,
});
const colorSpace = ColorSpace.parse(cs, xref, res, pdfFunctionFactory);
const colorSpace = ColorSpace.parse({
cs,
xref,
resources,
pdfFunctionFactory,
});
// prettier-ignore
const testSrc = new Uint8Array([
@ -448,12 +488,17 @@ describe("colorspace", function () {
data: new Dict(),
},
]);
const res = new Dict();
const resources = new Dict();
const pdfFunctionFactory = new PDFFunctionFactory({
xref,
});
const colorSpace = ColorSpace.parse(cs, xref, res, pdfFunctionFactory);
const colorSpace = ColorSpace.parse({
cs,
xref,
resources,
pdfFunctionFactory,
});
// prettier-ignore
const testSrc = new Uint8Array([
@ -502,12 +547,17 @@ describe("colorspace", function () {
data: new Dict(),
},
]);
const res = new Dict();
const resources = new Dict();
const pdfFunctionFactory = new PDFFunctionFactory({
xref,
});
const colorSpace = ColorSpace.parse(cs, xref, res, pdfFunctionFactory);
const colorSpace = ColorSpace.parse({
cs,
xref,
resources,
pdfFunctionFactory,
});
const testSrc = new Uint8Array([2, 2, 0, 1]);
const testDest = new Uint8ClampedArray(3 * 3 * 3);
@ -564,12 +614,17 @@ describe("colorspace", function () {
data: fn,
},
]);
const res = new Dict();
const resources = new Dict();
const pdfFunctionFactory = new PDFFunctionFactory({
xref,
});
const colorSpace = ColorSpace.parse(cs, xref, res, pdfFunctionFactory);
const colorSpace = ColorSpace.parse({
cs,
xref,
resources,
pdfFunctionFactory,
});
const testSrc = new Uint8Array([27, 25, 50, 31]);
const testDest = new Uint8ClampedArray(3 * 3 * 3);