From e20ef39f594492c3735206829b076ee981fe06d0 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Sat, 21 Oct 2023 16:02:05 +0200
Subject: [PATCH] Use a `ResizeObserver` to update the layout of `PDFFindBar`

*Please note:* In the Firefox PDF Viewer this findbar is only used for PDF documents placed in e.g. `<iframe>` elements.

By registering a `ResizeObserver` when the `PDFFindBar` is open we slightly unify and simplify how the findbar layout (row vs column) is handled.
This will be especially helpful with upcoming changes, where we'll make use of "data-l10n-id"/"data-l10n-args" to trigger translation in the viewer.
---
 web/pdf_find_bar.js | 34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/web/pdf_find_bar.js b/web/pdf_find_bar.js
index a9c626588..b1dfd5697 100644
--- a/web/pdf_find_bar.js
+++ b/web/pdf_find_bar.js
@@ -25,6 +25,8 @@ const MATCHES_COUNT_LIMIT = 1000;
  * is done by PDFFindController.
  */
 class PDFFindBar {
+  #resizeObserver = new ResizeObserver(this.#resizeObserverCallback.bind(this));
+
   constructor(options, eventBus, l10n) {
     this.opened = false;
 
@@ -87,8 +89,6 @@ class PDFFindBar {
     this.matchDiacritics.addEventListener("click", () => {
       this.dispatchEvent("diacriticmatchingchange");
     });
-
-    this.eventBus._on("resize", this.#adjustWidth.bind(this));
   }
 
   reset() {
@@ -134,7 +134,6 @@ class PDFFindBar {
     findMsg.then(msg => {
       this.findMsg.setAttribute("data-status", status);
       this.findMsg.textContent = msg;
-      this.#adjustWidth();
     });
 
     this.updateResultsCount(matchesCount);
@@ -152,27 +151,31 @@ class PDFFindBar {
     }
     matchCountMsg.then(msg => {
       this.findResultsCount.textContent = msg;
-      // Since `updateResultsCount` may be called from `PDFFindController`,
-      // ensure that the width of the findbar is always updated correctly.
-      this.#adjustWidth();
     });
   }
 
   open() {
     if (!this.opened) {
+      // Potentially update the findbar layout, row vs column, when:
+      //  - The width of the viewer itself changes.
+      //  - The width of the findbar changes, by toggling the visibility
+      //    (or localization) of find count/status messages.
+      this.#resizeObserver.observe(this.bar.parentNode);
+      this.#resizeObserver.observe(this.bar);
+
       this.opened = true;
       toggleExpandedBtn(this.toggleButton, true, this.bar);
     }
     this.findField.select();
     this.findField.focus();
-
-    this.#adjustWidth();
   }
 
   close() {
     if (!this.opened) {
       return;
     }
+    this.#resizeObserver.disconnect();
+
     this.opened = false;
     toggleExpandedBtn(this.toggleButton, false, this.bar);
 
@@ -187,25 +190,22 @@ class PDFFindBar {
     }
   }
 
-  #adjustWidth() {
-    if (!this.opened) {
-      return;
-    }
-
+  #resizeObserverCallback(entries) {
+    const { bar } = this;
     // The find bar has an absolute position and thus the browser extends
     // its width to the maximum possible width once the find bar does not fit
     // entirely within the window anymore (and its elements are automatically
     // wrapped). Here we detect and fix that.
-    this.bar.classList.remove("wrapContainers");
+    bar.classList.remove("wrapContainers");
 
-    const findbarHeight = this.bar.clientHeight;
-    const inputContainerHeight = this.bar.firstElementChild.clientHeight;
+    const findbarHeight = bar.clientHeight;
+    const inputContainerHeight = bar.firstElementChild.clientHeight;
 
     if (findbarHeight > inputContainerHeight) {
       // The findbar is taller than the input container, which means that
       // the browser wrapped some of the elements. For a consistent look,
       // wrap all of them to adjust the width of the find bar.
-      this.bar.classList.add("wrapContainers");
+      bar.classList.add("wrapContainers");
     }
   }
 }