mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-20 15:18:08 +02:00
Code Activity

Improve "EI" detection in inline images (PR 12028 follow-up, issue 16454)

Browse source 
Given that inline images may contain "EI"-sequences in the image-data itself, actually finding the end-of-image operator isn't always straightforward.
Here we extend the implementation from PR 12028 to potentially check all of the following bytes, rather than stopping immediately. While we have fairly decent test-coverage for this code, whenever you're changing it there's unfortunately a slightly higher than normal risk of regressions. (You'd really wish that PDF generators just stop using inline images.)
This commit is contained in:
Jonas Jenwald 2023-05-23 13:08:02 +02:00
parent 094fb3c783
commit dfbbb8c0ac
3 changed files with 56 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

1
test/pdfs/issue16454.pdf.link Normal file
View file

@ -0,0 +1 @@
https://github.com/mozilla/pdf.js/files/11537582/Pages.62.73.from.0560-22_WSP.Plan_July.2022_Version.1.pdf

8
test/test_manifest.json
View file

@ -5963,6 +5963,14 @@
"link": true,
"type": "eq"
},
{ "id": "issue16454",
"file": "pdfs/issue16454.pdf",
"md5": "82fe0c54a96667472ce999be7a789199",
"rounds": 1,
"lastPage": 1,
"link": true,
"type": "eq"
},
{ "id": "decodeACSuccessive",
"file": "pdfs/decodeACSuccessive.pdf",
"md5": "7749c032624fe27ab8e8d7d5e9a4a93f",