mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-26 10:08:06 +02:00
Code Activity

Whitelist closure related cases to address the remaining no-shadow linting errors

Browse source 
Given the way that "classes" were previously implemented in PDF.js, using regular functions and closures, there's a fair number of false positives when the `no-shadow` ESLint rule was enabled.

Note that while *some* of these `eslint-disable` statements can be removed if/when the relevant code is converted to proper `class`es, we'll probably never be able to get rid of all of them given our naming/coding conventions (however I don't really see this being a problem).
This commit is contained in:
Jonas Jenwald 2020-03-25 10:15:50 +01:00
parent 1d2f787d6a
commit dcb16af968
32 changed files with 109 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/core/evaluator.js
View file

@ -96,6 +96,7 @@ var PartialEvaluator = (function PartialEvaluatorClosure() {
isEvalSupported: true,
};
// eslint-disable-next-line no-shadow
function PartialEvaluator({
xref,
handler,
@ -3266,6 +3267,7 @@ var PartialEvaluator = (function PartialEvaluatorClosure() {
})();
var TranslatedFont = (function TranslatedFontClosure() {
// eslint-disable-next-line no-shadow
function TranslatedFont(loadedName, font, dict) {
this.loadedName = loadedName;
this.font = font;
@ -3367,6 +3369,7 @@ var TranslatedFont = (function TranslatedFontClosure() {
})();
var StateManager = (function StateManagerClosure() {
// eslint-disable-next-line no-shadow
function StateManager(initialState) {
this.state = initialState;
this.stateStack = [];
@ -3391,6 +3394,7 @@ var StateManager = (function StateManagerClosure() {
})();
var TextState = (function TextStateClosure() {
// eslint-disable-next-line no-shadow
function TextState() {
this.ctm = new Float32Array(IDENTITY_MATRIX);
this.fontName = null;
@ -3496,6 +3500,7 @@ var TextState = (function TextStateClosure() {
})();
var EvalState = (function EvalStateClosure() {
// eslint-disable-next-line no-shadow
function EvalState() {
this.ctm = new Float32Array(IDENTITY_MATRIX);
this.font = null;
@ -3637,6 +3642,7 @@ var EvaluatorPreprocessor = (function EvaluatorPreprocessorClosure() {
const MAX_INVALID_PATH_OPS = 20;
// eslint-disable-next-line no-shadow
function EvaluatorPreprocessor(stream, xref, stateManager) {
this.opMap = getOPMap();
// TODO(mduan): pass array of knownCommands rather than this.opMap