1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-20 07:08:08 +02:00

[Editor] Move setting window.uiManager back to the test code

In PR #18574 setting `window.uiManager` was moved into the `src` folder
to avoid intermittent integration test failures because at the time we
lacked a way to register event listeners early (before PDF.js loads).
However, in PR #18617 this functionality got introduced, so we can now
use the new way of setting up the event bus in the tests to move this
back to the `test` folder again and to reduce the amount of test-only
code in the main codebase as discussed in PR #18574.

Partially reverts e037c5711d.
This commit is contained in:
Tim van der Meij 2024-08-18 15:21:02 +02:00
parent b47c7eca83
commit db06011032
No known key found for this signature in database
GPG key ID: 8C3FD2925A5F2762
3 changed files with 14 additions and 3 deletions

View file

@ -806,7 +806,6 @@ class AnnotationEditorUIManager {
this.isShiftKeyDown = false;
if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("TESTING")) {
window.uiManager = this;
Object.defineProperty(this, "reset", {
value: () => {
this.selectAll();

View file

@ -990,7 +990,13 @@ describe("Highlight Editor", () => {
"tracemonkey.pdf",
".annotationEditorLayer",
null,
null,
{
eventBusSetup: eventBus => {
eventBus.on("annotationeditoruimanager", ({ uiManager }) => {
window.uiManager = uiManager;
});
},
},
{
highlightEditorColors: "red=#AB0000",
supportsCaretBrowsingMode: true,

View file

@ -832,7 +832,13 @@ describe("Stamp Editor", () => {
"empty.pdf",
".annotationEditorLayer",
null,
null,
{
eventBusSetup: eventBus => {
eventBus.on("annotationeditoruimanager", ({ uiManager }) => {
window.uiManager = uiManager;
});
},
},
{
enableAltText: true,
enableUpdatedAddImage: true,