mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 06:38:07 +02:00
Code Activity

[Editor] Fix the title of saved signature button (bug 1953298)

Browse source
This commit is contained in:
Calixte Denizet 2025-03-13 10:01:31 +01:00
parent 38cb01c629
commit da105f71f6
3 changed files with 21 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
web/signature_manager.js
View file

@ -708,11 +708,17 @@ class SignatureManager {
button.append(svg);
const span = document.createElement("span");
span.ariaHidden = true;
button.append(span);
button.classList.add("toolbarAddSignatureButton");
button.type = "button";
button.title = span.textContent = description;
span.textContent = description;
button.setAttribute(
"data-l10n-id",
"pdfjs-editor-add-saved-signature-button"
);
button.setAttribute("data-l10n-args", JSON.stringify({ description }));
button.tabIndex = 0;
const path = svgFactory.createElement("path");
@ -729,7 +735,7 @@ class SignatureManager {
deleteButton.classList.add("toolbarButton", "deleteButton");
deleteButton.setAttribute(
"data-l10n-id",
"pdfjs-editor-delete-signature-button"
"pdfjs-editor-delete-signature-button1"
);
deleteButton.type = "button";
deleteButton.tabIndex = 0;
@ -749,7 +755,7 @@ class SignatureManager {
deleteButton.append(deleteSpan);
deleteSpan.setAttribute(
"data-l10n-id",
"pdfjs-editor-delete-signature-button-label"
"pdfjs-editor-delete-signature-button-label1"
);
this.#addSignatureToolbarButton.before(div);

2
web/viewer.html
View file

@ -249,7 +249,7 @@ See https://github.com/adobe-type-tools/cmap-resources
<span data-l10n-id="pdfjs-editor-signature-button-label">Add signature</span>
</button>
<div class="editorParamsToolbar hidden doorHangerRight menu" id="editorSignatureParamsToolbar">
<div id="addSignatureDoorHanger" class="menuContainer">
<div id="addSignatureDoorHanger" class="menuContainer" role="region" data-l10n-id="pdfjs-editor-add-signature-container">
<button id="editorSignatureAddSignature" class="toolbarButton labeled" type="button" title="Add new signature" tabindex="0" data-l10n-id="pdfjs-editor-signature-add-signature-button">
<span data-l10n-id="pdfjs-editor-signature-add-signature-button-label" class="editorParamsLabel">Add new signature</span>
</button>