mirror of
https://github.com/mozilla/pdf.js.git
synced 2025-04-22 16:18:08 +02:00
[Editor] Update the parameters in the UI of the last selected editor when undoing/redoing
This commit is contained in:
parent
ae62787080
commit
d713df28c3
5 changed files with 149 additions and 51 deletions
|
@ -224,12 +224,9 @@ class FreeTextEditor extends AnnotationEditor {
|
|||
};
|
||||
const savedFontsize = this.#fontSize;
|
||||
this.addCommands({
|
||||
cmd: () => {
|
||||
setFontsize(fontSize);
|
||||
},
|
||||
undo: () => {
|
||||
setFontsize(savedFontsize);
|
||||
},
|
||||
cmd: setFontsize.bind(this, fontSize),
|
||||
undo: setFontsize.bind(this, savedFontsize),
|
||||
post: this._uiManager.updateUI.bind(this._uiManager, this),
|
||||
mustExec: true,
|
||||
type: AnnotationEditorParamsType.FREETEXT_SIZE,
|
||||
overwriteIfSameType: true,
|
||||
|
@ -242,14 +239,14 @@ class FreeTextEditor extends AnnotationEditor {
|
|||
* @param {string} color
|
||||
*/
|
||||
#updateColor(color) {
|
||||
const setColor = col => {
|
||||
this.#color = this.editorDiv.style.color = col;
|
||||
};
|
||||
const savedColor = this.#color;
|
||||
this.addCommands({
|
||||
cmd: () => {
|
||||
this.#color = this.editorDiv.style.color = color;
|
||||
},
|
||||
undo: () => {
|
||||
this.#color = this.editorDiv.style.color = savedColor;
|
||||
},
|
||||
cmd: setColor.bind(this, color),
|
||||
undo: setColor.bind(this, savedColor),
|
||||
post: this._uiManager.updateUI.bind(this._uiManager, this),
|
||||
mustExec: true,
|
||||
type: AnnotationEditorParamsType.FREETEXT_COLOR,
|
||||
overwriteIfSameType: true,
|
||||
|
|
|
@ -221,18 +221,16 @@ class HighlightEditor extends AnnotationEditor {
|
|||
* @param {string} color
|
||||
*/
|
||||
#updateColor(color) {
|
||||
const setColor = col => {
|
||||
this.color = col;
|
||||
this.parent?.drawLayer.changeColor(this.#id, col);
|
||||
this.#colorPicker?.updateColor(col);
|
||||
};
|
||||
const savedColor = this.color;
|
||||
this.addCommands({
|
||||
cmd: () => {
|
||||
this.color = color;
|
||||
this.parent?.drawLayer.changeColor(this.#id, color);
|
||||
this.#colorPicker?.updateColor(color);
|
||||
},
|
||||
undo: () => {
|
||||
this.color = savedColor;
|
||||
this.parent?.drawLayer.changeColor(this.#id, savedColor);
|
||||
this.#colorPicker?.updateColor(savedColor);
|
||||
},
|
||||
cmd: setColor.bind(this, color),
|
||||
undo: setColor.bind(this, savedColor),
|
||||
post: this._uiManager.updateUI.bind(this._uiManager, this),
|
||||
mustExec: true,
|
||||
type: AnnotationEditorParamsType.HIGHLIGHT_COLOR,
|
||||
overwriteIfSameType: true,
|
||||
|
|
|
@ -158,16 +158,15 @@ class InkEditor extends AnnotationEditor {
|
|||
* @param {number} thickness
|
||||
*/
|
||||
#updateThickness(thickness) {
|
||||
const setThickness = th => {
|
||||
this.thickness = th;
|
||||
this.#fitToContent();
|
||||
};
|
||||
const savedThickness = this.thickness;
|
||||
this.addCommands({
|
||||
cmd: () => {
|
||||
this.thickness = thickness;
|
||||
this.#fitToContent();
|
||||
},
|
||||
undo: () => {
|
||||
this.thickness = savedThickness;
|
||||
this.#fitToContent();
|
||||
},
|
||||
cmd: setThickness.bind(this, thickness),
|
||||
undo: setThickness.bind(this, savedThickness),
|
||||
post: this._uiManager.updateUI.bind(this._uiManager, this),
|
||||
mustExec: true,
|
||||
type: AnnotationEditorParamsType.INK_THICKNESS,
|
||||
overwriteIfSameType: true,
|
||||
|
@ -180,16 +179,15 @@ class InkEditor extends AnnotationEditor {
|
|||
* @param {string} color
|
||||
*/
|
||||
#updateColor(color) {
|
||||
const setColor = col => {
|
||||
this.color = col;
|
||||
this.#redraw();
|
||||
};
|
||||
const savedColor = this.color;
|
||||
this.addCommands({
|
||||
cmd: () => {
|
||||
this.color = color;
|
||||
this.#redraw();
|
||||
},
|
||||
undo: () => {
|
||||
this.color = savedColor;
|
||||
this.#redraw();
|
||||
},
|
||||
cmd: setColor.bind(this, color),
|
||||
undo: setColor.bind(this, savedColor),
|
||||
post: this._uiManager.updateUI.bind(this._uiManager, this),
|
||||
mustExec: true,
|
||||
type: AnnotationEditorParamsType.INK_COLOR,
|
||||
overwriteIfSameType: true,
|
||||
|
@ -202,17 +200,16 @@ class InkEditor extends AnnotationEditor {
|
|||
* @param {number} opacity
|
||||
*/
|
||||
#updateOpacity(opacity) {
|
||||
const setOpacity = op => {
|
||||
this.opacity = op;
|
||||
this.#redraw();
|
||||
};
|
||||
opacity /= 100;
|
||||
const savedOpacity = this.opacity;
|
||||
this.addCommands({
|
||||
cmd: () => {
|
||||
this.opacity = opacity;
|
||||
this.#redraw();
|
||||
},
|
||||
undo: () => {
|
||||
this.opacity = savedOpacity;
|
||||
this.#redraw();
|
||||
},
|
||||
cmd: setOpacity.bind(this, opacity),
|
||||
undo: setOpacity.bind(this, savedOpacity),
|
||||
post: this._uiManager.updateUI.bind(this._uiManager, this),
|
||||
mustExec: true,
|
||||
type: AnnotationEditorParamsType.INK_OPACITY,
|
||||
overwriteIfSameType: true,
|
||||
|
|
|
@ -244,6 +244,7 @@ class CommandManager {
|
|||
* @typedef {Object} addOptions
|
||||
* @property {function} cmd
|
||||
* @property {function} undo
|
||||
* @property {function} [post]
|
||||
* @property {boolean} mustExec
|
||||
* @property {number} type
|
||||
* @property {boolean} overwriteIfSameType
|
||||
|
@ -257,6 +258,7 @@ class CommandManager {
|
|||
add({
|
||||
cmd,
|
||||
undo,
|
||||
post,
|
||||
mustExec,
|
||||
type = NaN,
|
||||
overwriteIfSameType = false,
|
||||
|
@ -270,7 +272,7 @@ class CommandManager {
|
|||
return;
|
||||
}
|
||||
|
||||
const save = { cmd, undo, type };
|
||||
const save = { cmd, undo, post, type };
|
||||
if (this.#position === -1) {
|
||||
if (this.#commands.length > 0) {
|
||||
// All the commands have been undone and then a new one is added
|
||||
|
@ -317,7 +319,9 @@ class CommandManager {
|
|||
|
||||
// Avoid to insert something during the undo execution.
|
||||
this.#locked = true;
|
||||
this.#commands[this.#position].undo();
|
||||
const { undo, post } = this.#commands[this.#position];
|
||||
undo();
|
||||
post?.();
|
||||
this.#locked = false;
|
||||
|
||||
this.#position -= 1;
|
||||
|
@ -332,7 +336,9 @@ class CommandManager {
|
|||
|
||||
// Avoid to insert something during the redo execution.
|
||||
this.#locked = true;
|
||||
this.#commands[this.#position].cmd();
|
||||
const { cmd, post } = this.#commands[this.#position];
|
||||
cmd();
|
||||
post?.();
|
||||
this.#locked = false;
|
||||
}
|
||||
}
|
||||
|
@ -1442,6 +1448,24 @@ class AnnotationEditorUIManager {
|
|||
}
|
||||
}
|
||||
|
||||
get #lastSelectedEditor() {
|
||||
let ed = null;
|
||||
for (ed of this.#selectedEditors) {
|
||||
// Iterate to get the last element.
|
||||
}
|
||||
return ed;
|
||||
}
|
||||
|
||||
/**
|
||||
* Update the UI of the active editor.
|
||||
* @param {AnnotationEditor} editor
|
||||
*/
|
||||
updateUI(editor) {
|
||||
if (this.#lastSelectedEditor === editor) {
|
||||
this.#dispatchUpdateUI(editor.propertiesToUpdate);
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Add or remove an editor the current selection.
|
||||
* @param {AnnotationEditor} editor
|
||||
|
@ -1607,6 +1631,9 @@ class AnnotationEditorUIManager {
|
|||
* @param {Array<AnnotationEditor>} editors
|
||||
*/
|
||||
#selectEditors(editors) {
|
||||
for (const editor of this.#selectedEditors) {
|
||||
editor.unselect();
|
||||
}
|
||||
this.#selectedEditors.clear();
|
||||
for (const editor of editors) {
|
||||
if (editor.isEmpty()) {
|
||||
|
@ -1615,7 +1642,7 @@ class AnnotationEditorUIManager {
|
|||
this.#selectedEditors.add(editor);
|
||||
editor.select();
|
||||
}
|
||||
this.#dispatchUpdateStates({ hasSelectedEditor: true });
|
||||
this.#dispatchUpdateStates({ hasSelectedEditor: this.hasSelection });
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue