mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 06:38:07 +02:00
Code Activity

Merge pull request #19649 from calixteman/bug1953298

Browse source 
[Editor] Fix the title of saved signature button (bug 1953298)
This commit is contained in:
calixteman 2025-03-13 13:50:43 +01:00 • committed by GitHub
commit d5c185b90a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 21 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
l10n/en-US/viewer.ftl
View file

@ -365,10 +365,18 @@ pdfjs-editor-stamp-add-image-button-label = Add image
pdfjs-editor-free-highlight-thickness-input = Thickness pdfjs-editor-free-highlight-thickness-input = Thickness
pdfjs-editor-free-highlight-thickness-title = pdfjs-editor-free-highlight-thickness-title =
.title = Change thickness when highlighting items other than text .title = Change thickness when highlighting items other than text
pdfjs-editor-add-signature-container =
.aria-label = Signature controls and saved signatures
pdfjs-editor-signature-add-signature-button = pdfjs-editor-signature-add-signature-button =
.title = Add new signature .title = Add new signature
pdfjs-editor-signature-add-signature-button-label = Add new signature pdfjs-editor-signature-add-signature-button-label = Add new signature
# Used on the button to use an already saved signature.
# Variables:
# description (String) - a string describing/labeling the signature.
pdfjs-editor-add-saved-signature-button =
.title = Saved signature: { $description }
# .default-content is used as a placeholder in an empty text editor. # .default-content is used as a placeholder in an empty text editor.
pdfjs-free-text2 = pdfjs-free-text2 =
.aria-label = Text Editor .aria-label = Text Editor
@ -603,9 +611,9 @@ pdfjs-editor-add-signature-add-button = Add
## Main menu for adding/removing signatures ## Main menu for adding/removing signatures
pdfjs-editor-delete-signature-button = pdfjs-editor-delete-signature-button1 =
.title = Remove signature .title = Remove saved signature
pdfjs-editor-delete-signature-button-label = Remove signature pdfjs-editor-delete-signature-button-label1 = Remove saved signature
## Editor toolbar ## Editor toolbar

12
web/signature_manager.js
View file

@ -708,11 +708,17 @@ class SignatureManager {
button.append(svg); button.append(svg);
const span = document.createElement("span"); const span = document.createElement("span");
span.ariaHidden = true;
button.append(span); button.append(span);
button.classList.add("toolbarAddSignatureButton"); button.classList.add("toolbarAddSignatureButton");
button.type = "button"; button.type = "button";
button.title = span.textContent = description; span.textContent = description;
button.setAttribute(
"data-l10n-id",
"pdfjs-editor-add-saved-signature-button"
);
button.setAttribute("data-l10n-args", JSON.stringify({ description }));
button.tabIndex = 0; button.tabIndex = 0;
const path = svgFactory.createElement("path"); const path = svgFactory.createElement("path");
@ -729,7 +735,7 @@ class SignatureManager {
deleteButton.classList.add("toolbarButton", "deleteButton"); deleteButton.classList.add("toolbarButton", "deleteButton");
deleteButton.setAttribute( deleteButton.setAttribute(
"data-l10n-id", "data-l10n-id",
"pdfjs-editor-delete-signature-button" "pdfjs-editor-delete-signature-button1"
); );
deleteButton.type = "button"; deleteButton.type = "button";
deleteButton.tabIndex = 0; deleteButton.tabIndex = 0;
@ -749,7 +755,7 @@ class SignatureManager {
deleteButton.append(deleteSpan); deleteButton.append(deleteSpan);
deleteSpan.setAttribute( deleteSpan.setAttribute(
"data-l10n-id", "data-l10n-id",
"pdfjs-editor-delete-signature-button-label" "pdfjs-editor-delete-signature-button-label1"
); );
this.#addSignatureToolbarButton.before(div); this.#addSignatureToolbarButton.before(div);

2
web/viewer.html
View file

@ -249,7 +249,7 @@ See https://github.com/adobe-type-tools/cmap-resources
<span data-l10n-id="pdfjs-editor-signature-button-label">Add signature</span> <span data-l10n-id="pdfjs-editor-signature-button-label">Add signature</span>
</button> </button>
<div class="editorParamsToolbar hidden doorHangerRight menu" id="editorSignatureParamsToolbar"> <div class="editorParamsToolbar hidden doorHangerRight menu" id="editorSignatureParamsToolbar">
<div id="addSignatureDoorHanger" class="menuContainer"> <div id="addSignatureDoorHanger" class="menuContainer" role="region" data-l10n-id="pdfjs-editor-add-signature-container">
<button id="editorSignatureAddSignature" class="toolbarButton labeled" type="button" title="Add new signature" tabindex="0" data-l10n-id="pdfjs-editor-signature-add-signature-button"> <button id="editorSignatureAddSignature" class="toolbarButton labeled" type="button" title="Add new signature" tabindex="0" data-l10n-id="pdfjs-editor-signature-add-signature-button">
<span data-l10n-id="pdfjs-editor-signature-add-signature-button-label" class="editorParamsLabel">Add new signature</span> <span data-l10n-id="pdfjs-editor-signature-add-signature-button-label" class="editorParamsLabel">Add new signature</span>
</button> </button>