From d3044ac394294657fce83ac84c6c7a77f0ce68f4 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Sun, 22 Mar 2020 15:46:50 +0100
Subject: [PATCH] Remove unnecessary checks from the `PDFDocumentProperties`
 constructor

Given that none of the relevant options are marked as optional in the code/JSDocs, and that the `PDFDocumentProperties` class is specific to the default viewer (and not exposed as part of the viewer components), there's no good reason as far as I can tell for these checks.
---
 web/pdf_document_properties.js | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/web/pdf_document_properties.js b/web/pdf_document_properties.js
index 94586cc83..d22cfcc12 100644
--- a/web/pdf_document_properties.js
+++ b/web/pdf_document_properties.js
@@ -72,25 +72,21 @@ class PDFDocumentProperties {
     this.l10n = l10n;
 
     this._reset();
+    // Bind the event listener for the Close button.
+    closeButton.addEventListener("click", this.close.bind(this));
 
-    if (closeButton) {
-      // Bind the event listener for the Close button.
-      closeButton.addEventListener("click", this.close.bind(this));
-    }
     this.overlayManager.register(
       this.overlayName,
       this.container,
       this.close.bind(this)
     );
 
-    if (eventBus) {
-      eventBus._on("pagechanging", evt => {
-        this._currentPageNumber = evt.pageNumber;
-      });
-      eventBus._on("rotationchanging", evt => {
-        this._pagesRotation = evt.pagesRotation;
-      });
-    }
+    eventBus._on("pagechanging", evt => {
+      this._currentPageNumber = evt.pageNumber;
+    });
+    eventBus._on("rotationchanging", evt => {
+      this._pagesRotation = evt.pagesRotation;
+    });
 
     this._isNonMetricLocale = true; // The default viewer locale is 'en-us'.
     l10n.getLanguage().then(locale => {