mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-21 23:58:07 +02:00
Code Activity

Invalidate an annotation with no quadPoints (when it's required)

Browse source 
Some pdf softwares don't remove highlight annotations but make the QuadPoints array empty.
And the Rect for the annotation can be [-32768, -32768, 32768, 32768] so it leads to have a giant div which catches all the mouse events and make the pdf unusable when there are some forms elements.
This commit is contained in:
Calixte Denizet 2020-10-21 12:00:34 +02:00
parent 4b4ac8a13d
commit d2ef878702
2 changed files with 65 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

38
test/unit/annotation_spec.js
View file

@ -3367,7 +3367,7 @@ describe("annotation", function () {
});
describe("HightlightAnnotation", function () {
it("should not set quadpoints if not defined", function (done) {
it("should set quadpoints to null if not defined", function (done) {
const highlightDict = new Dict();
highlightDict.set("Type", Name.get("Annot"));
highlightDict.set("Subtype", Name.get("Highlight"));
@ -3382,7 +3382,7 @@ describe("annotation", function () {
idFactoryMock
).then(({ data }) => {
expect(data.annotationType).toEqual(AnnotationType.HIGHLIGHT);
expect(data.quadPoints).toBeUndefined();
expect(data.quadPoints).toEqual(null);
done();
}, done.fail);
});
@ -3415,10 +3415,32 @@ describe("annotation", function () {
done();
}, done.fail);
});
it("should set quadpoints to null when empty", function (done) {
const highlightDict = new Dict();
highlightDict.set("Type", Name.get("Annot"));
highlightDict.set("Subtype", Name.get("Highlight"));
highlightDict.set("Rect", [10, 10, 20, 20]);
highlightDict.set("QuadPoints", []);
const highlightRef = Ref.get(121, 0);
const xref = new XRefMock([{ ref: highlightRef, data: highlightDict }]);
AnnotationFactory.create(
xref,
highlightRef,
pdfManagerMock,
idFactoryMock
).then(({ data }) => {
expect(data.annotationType).toEqual(AnnotationType.HIGHLIGHT);
expect(data.quadPoints).toEqual(null);
done();
}, done.fail);
});
});
describe("UnderlineAnnotation", function () {
it("should not set quadpoints if not defined", function (done) {
it("should set quadpoints to null if not defined", function (done) {
const underlineDict = new Dict();
underlineDict.set("Type", Name.get("Annot"));
underlineDict.set("Subtype", Name.get("Underline"));
@ -3433,7 +3455,7 @@ describe("annotation", function () {
idFactoryMock
).then(({ data }) => {
expect(data.annotationType).toEqual(AnnotationType.UNDERLINE);
expect(data.quadPoints).toBeUndefined();
expect(data.quadPoints).toEqual(null);
done();
}, done.fail);
});
@ -3469,7 +3491,7 @@ describe("annotation", function () {
});
describe("SquigglyAnnotation", function () {
it("should not set quadpoints if not defined", function (done) {
it("should set quadpoints to null if not defined", function (done) {
const squigglyDict = new Dict();
squigglyDict.set("Type", Name.get("Annot"));
squigglyDict.set("Subtype", Name.get("Squiggly"));
@ -3484,7 +3506,7 @@ describe("annotation", function () {
idFactoryMock
).then(({ data }) => {
expect(data.annotationType).toEqual(AnnotationType.SQUIGGLY);
expect(data.quadPoints).toBeUndefined();
expect(data.quadPoints).toEqual(null);
done();
}, done.fail);
});
@ -3520,7 +3542,7 @@ describe("annotation", function () {
});
describe("StrikeOutAnnotation", function () {
it("should not set quadpoints if not defined", function (done) {
it("should set quadpoints to null if not defined", function (done) {
const strikeOutDict = new Dict();
strikeOutDict.set("Type", Name.get("Annot"));
strikeOutDict.set("Subtype", Name.get("StrikeOut"));
@ -3535,7 +3557,7 @@ describe("annotation", function () {
idFactoryMock
).then(({ data }) => {
expect(data.annotationType).toEqual(AnnotationType.STRIKEOUT);
expect(data.quadPoints).toBeUndefined();
expect(data.quadPoints).toEqual(null);
done();
}, done.fail);
});