mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-22 16:18:08 +02:00
Code Activity

Ensure that Annotation appearance-entries are actually Streams

Browse source 
Note how all over the `src/core/annotation.js`-code we're assuming that if an `appearance`-entry exists it's also a Stream. However, we're not actually checking that thoroughly enough which causes issues in some badly generated PDF documents.
This commit is contained in:
Jonas Jenwald 2023-01-16 12:56:43 +01:00
parent e9c8aa63e3
commit cefaecc2e8
4 changed files with 22 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/core/annotation.js
View file

@ -866,7 +866,10 @@ class Annotation {
if (!(as instanceof Name) || !normalAppearanceState.has(as.name)) {
return;
}
this.appearance = normalAppearanceState.get(as.name);
const appearance = normalAppearanceState.get(as.name);
if (appearance instanceof BaseStream) {
this.appearance = appearance;
}
}
setOptionalContent(dict) {
@ -3013,9 +3016,12 @@ class ButtonWidgetAnnotation extends WidgetAnnotation {
this.data.exportValue = exportValues[1];
const checkedAppearance = normalAppearance.get(this.data.exportValue);
this.checkedAppearance =
normalAppearance.get(this.data.exportValue) || null;
this.uncheckedAppearance = normalAppearance.get("Off") || null;
checkedAppearance instanceof BaseStream ? checkedAppearance : null;
const uncheckedAppearance = normalAppearance.get("Off");
this.uncheckedAppearance =
uncheckedAppearance instanceof BaseStream ? uncheckedAppearance : null;
if (this.checkedAppearance) {
this._streams.push(this.checkedAppearance);
@ -3058,9 +3064,12 @@ class ButtonWidgetAnnotation extends WidgetAnnotation {
}
}
const checkedAppearance = normalAppearance.get(this.data.buttonValue);
this.checkedAppearance =
normalAppearance.get(this.data.buttonValue) || null;
this.uncheckedAppearance = normalAppearance.get("Off") || null;
checkedAppearance instanceof BaseStream ? checkedAppearance : null;
const uncheckedAppearance = normalAppearance.get("Off");
this.uncheckedAppearance =
uncheckedAppearance instanceof BaseStream ? uncheckedAppearance : null;
if (this.checkedAppearance) {
this._streams.push(this.checkedAppearance);