1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-24 09:08:07 +02:00

Remove the dependency between two ink editor integration tests

The second test of the basic operations block for the ink editor
depends on the first test to work. This becomes visible if we only run
the second test, using `fit`, which always fails with:

`ProtocolError: Waiting for selector '.annotationEditorLayer' failed:
Runtime.callFunctionOn timed out. Increase the 'protocolTimeout' setting
in launch/connect calls for a higher timeout if needed.`

The problem is that the second test doesn't enable the ink editor and
relies on the first test having done that already (because we don't
close the document between tests yet). This commit fixes the issue by
unconditionally enabling the ink editor in the second test to remove the
dependency between the two tests so they both pass in isolation.
This commit is contained in:
Tim van der Meij 2025-02-09 16:27:16 +01:00
parent c1035e4356
commit ced1268ec3
No known key found for this signature in database
GPG key ID: 8C3FD2925A5F2762

View file

@ -113,6 +113,8 @@ describe("Ink Editor", () => {
pages.map(async ([browserName, page]) => {
await clearAll(page);
await switchToInk(page);
const rect = await getRect(page, ".annotationEditorLayer");
const xStart = rect.x + 300;