mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-22 16:18:08 +02:00
Code Activity

[api-minor] Change PageViewport to throw when the rotation is not a multiple of 90 degrees

Browse source 
As evident from the code, `PageViewport` only supports[1] `rotation` values which are a multiple of 90 degrees. Besides it being somewhat difficult to imagine meaningful use-cases for a non-multiple of 90 degrees `rotation`, the code also becomes both simpler and more efficient by not having to consider arbitrary `rotation` values.

However, any invalid rotation will *silently* fallback to assume zero `rotation` which probably isn't great for e.g. `PDFPageProxy.getViewport` in the API. Hence this patch, which will now enforce that only valid `rotation` values are accepted.

---
[1] As far as I can tell, from looking through the history, nothing else has ever been supported either.
This commit is contained in:
Jonas Jenwald 2020-04-22 15:18:27 +02:00
parent 571f287983
commit cdc60402f6
2 changed files with 15 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/display/display_utils.js
View file

@ -245,13 +245,16 @@ class PageViewport {
rotateC = -1;
rotateD = 0;
break;
// case 0:
default:
case 0:
rotateA = 1;
rotateB = 0;
rotateC = 0;
rotateD = -1;
break;
default:
throw new Error(
"PageViewport: Invalid rotation, must be a multiple of 90 degrees."
);
}
if (dontFlip) {