From cd22c317522e4e3f319069a7bdc7c96b0d1270fb Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sun, 3 Oct 2021 15:32:33 +0200 Subject: [PATCH] Fix the remaining `Promise.resolve(undefined)` cases Many years ago now there were some `Promise` implementations that had issues resolving with an *implicitly* `undefined` value. That should no longer be the case, and we've not been using the `Promise.resolve(undefined)` format for a long time, hence this patch fixes the few remaining cases. --- web/pdf_page_view.js | 2 +- web/pdf_thumbnail_view.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/web/pdf_page_view.js b/web/pdf_page_view.js index cac0ae619..aea372e07 100644 --- a/web/pdf_page_view.js +++ b/web/pdf_page_view.js @@ -831,7 +831,7 @@ class PDFPageView { renderTask.promise.then( function () { showCanvas(); - renderCapability.resolve(undefined); + renderCapability.resolve(); }, function (error) { showCanvas(); diff --git a/web/pdf_thumbnail_view.js b/web/pdf_thumbnail_view.js index 74fc2eaeb..4b43d26f1 100644 --- a/web/pdf_thumbnail_view.js +++ b/web/pdf_thumbnail_view.js @@ -278,7 +278,7 @@ class PDFThumbnailView { draw() { if (this.renderingState !== RenderingStates.INITIAL) { console.error("Must be in new state before drawing"); - return Promise.resolve(undefined); + return Promise.resolve(); } const { pdfPage } = this;