From c7de6dbe4113de8e71827cddd7b5b11a1cd0fef6 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Mon, 15 Jul 2019 11:19:17 +0200 Subject: [PATCH] Update the `fingerprint` API unit-tests to explicitly check for the expected result The current tests won't catch inadvertent changes to the logic used to obtain/compute the document `fingerprint`. --- test/unit/api_spec.js | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/test/unit/api_spec.js b/test/unit/api_spec.js index 10325b9f3..b32014e08 100644 --- a/test/unit/api_spec.js +++ b/test/unit/api_spec.js @@ -413,9 +413,7 @@ describe('api', function() { expect(doc.numPages).toEqual(3); }); it('gets fingerprint', function() { - var fingerprint = doc.fingerprint; - expect(typeof fingerprint).toEqual('string'); - expect(fingerprint.length > 0).toEqual(true); + expect(doc.fingerprint).toEqual('ea8b35919d6279a369e835bde778611b'); }); it('gets page', function(done) { var promise = doc.getPage(1); @@ -934,23 +932,22 @@ describe('api', function() { }); it('checks that fingerprints are unique', function(done) { - var loadingTask1 = getDocument(buildGetDocumentParams('issue4436r.pdf')); + const loadingTask1 = getDocument( + buildGetDocumentParams('issue4436r.pdf')); + const loadingTask2 = getDocument(buildGetDocumentParams('issue4575.pdf')); - var loadingTask2 = getDocument(buildGetDocumentParams('issue4575.pdf')); - - var promises = [loadingTask1.promise, - loadingTask2.promise]; - Promise.all(promises).then(function (data) { - var fingerprint1 = data[0].fingerprint; - expect(typeof fingerprint1).toEqual('string'); - expect(fingerprint1.length > 0).toEqual(true); - - var fingerprint2 = data[1].fingerprint; - expect(typeof fingerprint2).toEqual('string'); - expect(fingerprint2.length > 0).toEqual(true); + Promise.all([ + loadingTask1.promise, + loadingTask2.promise + ]).then(function(data) { + const fingerprint1 = data[0].fingerprint; + const fingerprint2 = data[1].fingerprint; expect(fingerprint1).not.toEqual(fingerprint2); + expect(fingerprint1).toEqual('2f695a83d6e7553c24fc08b7ac69712d'); + expect(fingerprint2).toEqual('04c7126b34a46b6d4d6e7a1eff7edcb6'); + Promise.all([ loadingTask1.destroy(), loadingTask2.destroy()