mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 22:58:07 +02:00
Code Activity

Add a new helper, in the viewer, to close everything during testing

Browse source 
This has two advantages, as far as I'm concerned:
 - The tests don't need to manually invoke multiple functions to properly clean-up, which reduces the risk of missing something.
 - By collecting all the relevant clean-up in one method, rather than spreading it out, we get a much better overview of exactly what is being reset.
This commit is contained in:
Jonas Jenwald 2024-06-19 07:45:34 +02:00
parent c53f71a7d2
commit c771ac81cd
2 changed files with 16 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

23
web/app.js
View file

@ -2105,14 +2105,21 @@ const PDFViewerApplication = {
unbindWindowEvents() {
this._windowAbortController?.abort();
this._windowAbortController = null;
if (
(typeof PDFJSDev !== "undefined" && PDFJSDev.test("TESTING")) ||
AppOptions.get("isInAutomation")
) {
this._globalAbortController?.abort();
this._globalAbortController = null;
this.l10n?.pause();
}
},
/**
* @ignore
*/
async testingClose() {
this.l10n?.pause();
this.unbindEvents();
this.unbindWindowEvents();
this._globalAbortController?.abort();
this._globalAbortController = null;
await this.close();
},
_accumulateTicks(ticks, prop) {