diff --git a/src/shared/compatibility.js b/src/shared/compatibility.js index 2bfc74c0f..1a9fcdc30 100644 --- a/src/shared/compatibility.js +++ b/src/shared/compatibility.js @@ -348,6 +348,14 @@ PDFJS.compatibilityChecked = true; Array.prototype.includes = require('core-js/fn/array/includes'); })(); +// Provides support for Math.log2 in legacy browsers. +// Support: IE. +(function checkMathLog2() { + if (Math.log2) { + return; + } + Math.log2 = require('core-js/fn/math/log2'); +})(); // Provides support for Number.isNaN in legacy browsers. // Support: IE. diff --git a/src/shared/util.js b/src/shared/util.js index 0dd597e2c..93d6f1583 100644 --- a/src/shared/util.js +++ b/src/shared/util.js @@ -600,13 +600,14 @@ function string32(value) { (value >> 8) & 0xff, value & 0xff); } +// Calculate the base 2 logarithm of the number `x`. This differs from the +// native function in the sense that it returns the ceiling value and that it +// returns 0 instead of `Infinity`/`NaN` for `x` values smaller than/equal to 0. function log2(x) { - var n = 1, i = 0; - while (x > n) { - n <<= 1; - i++; + if (x <= 0) { + return 0; } - return i; + return Math.ceil(Math.log2(x)); } function readInt8(data, start) { diff --git a/test/unit/util_spec.js b/test/unit/util_spec.js index 798404bd0..c5e18d564 100644 --- a/test/unit/util_spec.js +++ b/test/unit/util_spec.js @@ -15,7 +15,7 @@ import { bytesToString, isArrayBuffer, isBool, isEmptyObj, isNum, isSpace, isString, - ReadableStream, removeNullCharacters, stringToBytes, stringToPDFString + log2, ReadableStream, removeNullCharacters, stringToBytes, stringToPDFString } from '../../src/shared/util'; describe('util', function() { @@ -136,6 +136,20 @@ describe('util', function() { }); }); + describe('log2', function() { + it('handles values smaller than/equal to zero', function() { + expect(log2(0)).toEqual(0); + expect(log2(-1)).toEqual(0); + }); + + it('handles values larger than zero', function() { + expect(log2(1)).toEqual(0); + expect(log2(2)).toEqual(1); + expect(log2(3)).toEqual(2); + expect(log2(3.14)).toEqual(2); + }); + }); + describe('stringToBytes', function() { it('handles non-string arguments', function() { expect(function() {