From c3433aea482fe1e5b52a05bd2c148193ac85a824 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Mon, 23 Jul 2018 20:12:24 +0200 Subject: [PATCH] Remove a (now) unnecessary `externalLinkTarget` check in `PDFViewerApplication._readPreferences` The only reason that this check ever existed in the first place, is that originally there was a global `PDFJS.openExternalLinkInNewWindow` option which was then subsumed by the (more generic) `PDFJS.externalLinkTarget` option. (The `externalLinkTarget` has since been moved into a `PDFLinkService` option, as part of PDF.js version `2.0`.) Hence, during the period where both `PDFJS.openExternalLinkInNewWindow` and `PDFJS.externalLinkTarget` existed side-by-side, there was a need to allow the former one to override the latter one (for backward compatibility purposes). However, that's no longer the case, and this extra `externalLinkTarget` check can now be removed. --- web/app.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/web/app.js b/web/app.js index 2530329ee..69017d938 100644 --- a/web/app.js +++ b/web/app.js @@ -223,9 +223,6 @@ let PDFViewerApplication = { AppOptions.set('useOnlyCssZoom', value); }), preferences.get('externalLinkTarget').then(function resolved(value) { - if (AppOptions.get('externalLinkTarget') !== LinkTarget.NONE) { - return; - } AppOptions.set('externalLinkTarget', value); }), preferences.get('renderer').then(function resolved(value) {