mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-20 15:18:08 +02:00
Code Activity

[api-minor] Expose the /Desc-attribute of file attachments in the viewer (issue 18030)

Browse source 
In the viewer this will be displayed in the `title` of the hyperlink, which is probably the best we can do here given how the viewer is implemented.
This commit is contained in:
Jonas Jenwald 2024-04-30 18:51:31 +02:00
parent 1241758605
commit bf4e36d1b5
7 changed files with 48 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

11
web/pdf_attachment_viewer.js
View file

@ -94,7 +94,10 @@ class PDFAttachmentViewer extends BaseTreeViewer {
/**
* @protected
*/
_bindLink(element, { content, filename }) {
_bindLink(element, { content, description, filename }) {
if (description) {
element.title = description;
}
element.onclick = () => {
this.downloadManager.openOrDownloadData(content, filename);
return false;
@ -120,6 +123,7 @@ class PDFAttachmentViewer extends BaseTreeViewer {
for (const name in attachments) {
const item = attachments[name];
const content = item.content,
description = item.description,
filename = getFilenameFromUrl(
item.filename,
/* onlyStripPath = */ true
@ -129,7 +133,7 @@ class PDFAttachmentViewer extends BaseTreeViewer {
div.className = "treeItem";
const element = document.createElement("a");
this._bindLink(element, { content, filename });
this._bindLink(element, { content, description, filename });
element.textContent = this._normalizeTextContent(filename);
div.append(element);
@ -144,7 +148,7 @@ class PDFAttachmentViewer extends BaseTreeViewer {
/**
* Used to append FileAttachment annotations to the sidebar.
*/
#appendAttachment({ filename, content }) {
#appendAttachment({ filename, content, description }) {
const renderedPromise = this._renderedCapability.promise;
renderedPromise.then(() => {
@ -161,6 +165,7 @@ class PDFAttachmentViewer extends BaseTreeViewer {
attachments[filename] = {
filename,
content,
description,
};
this.render({
attachments,