mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 06:38:07 +02:00
Code Activity

Remove the eslint-plugin-mozilla dependency

Browse source 
We only used two rules from the plugin which can both easily be replaced
nowadays:

- `mozilla/avoid-removeChild` is equal to the already active
  `unicorn/prefer-dom-node-remove` rule; please see [1] and [2].
- `mozilla/import-globals` is mostly obsolete nowadays ever since we
  removed the Firefox extension code from this repository and we
  eliminated most globals usage. The three remaining occurrences can be
  replaced with explicit `/* globals */` comments that we already use
  elsewhere, which overall is also more consistent.

[1] https://firefox-source-docs.mozilla.org/code-quality/lint/linters/eslint-plugin-mozilla/rules/avoid-removeChild.html
[2] https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-dom-node-remove.md
This commit is contained in:
Tim van der Meij 2024-08-08 19:51:20 +02:00
parent cd3d188f99
commit be93d530de
No known key found for this signature in database
GPG key ID: 8C3FD2925A5F2762
7 changed files with 3 additions and 439 deletions
Download patch file Download diff file Expand all files Collapse all files

1
package.json
View file

@ -23,7 +23,6 @@
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-jasmine": "^4.2.0",
"eslint-plugin-json": "^3.1.0",
"eslint-plugin-mozilla": "^3.7.4",
"eslint-plugin-no-unsanitized": "^4.0.2",
"eslint-plugin-prettier": "^5.2.1",
"eslint-plugin-sort-exports": "^0.9.1",