From 5ab01e2cd0e67949d795224449d8a8d581f9c94f Mon Sep 17 00:00:00 2001 From: Kalervo Kujala Date: Sat, 3 Sep 2011 21:41:50 +0300 Subject: [PATCH 1/2] Fix xref bug. Use this.xref instead of xref in fetchDestinations function. --- pdf.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pdf.js b/pdf.js index 71a734f63..cf9615875 100644 --- a/pdf.js +++ b/pdf.js @@ -3547,7 +3547,7 @@ var Catalog = (function() { }, get destinations() { function fetchDestination(ref) { - var dest = xref.fetchIfRef(ref); + var dest = this.xref.fetchIfRef(ref); return IsDict(dest) ? dest.get('D') : dest; } From 2b5ed9b0fc943a6ad5529004b00d8a4aa511d958 Mon Sep 17 00:00:00 2001 From: Kalervo Kujala Date: Sat, 3 Sep 2011 22:28:45 +0300 Subject: [PATCH 2/2] Address comments for xref bug. --- pdf.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pdf.js b/pdf.js index cf9615875..8303bb650 100644 --- a/pdf.js +++ b/pdf.js @@ -3546,8 +3546,8 @@ var Catalog = (function() { } }, get destinations() { - function fetchDestination(ref) { - var dest = this.xref.fetchIfRef(ref); + function fetchDestination(xref, ref) { + var dest = xref.fetchIfRef(ref); return IsDict(dest) ? dest.get('D') : dest; } @@ -3564,7 +3564,7 @@ var Catalog = (function() { obj = xref.fetchIfRef(nameDictionaryRef); obj.forEach(function(key, value) { if (!value) return; - dests[key] = fetchDestination(value); + dests[key] = fetchDestination(xref, value); }); } if (nameTreeRef) { @@ -3588,7 +3588,7 @@ var Catalog = (function() { } var names = obj.get('Names'); for (i = 0, n = names.length; i < n; i += 2) { - dests[names[i]] = fetchDestination(names[i + 1]); + dests[names[i]] = fetchDestination(xref, names[i + 1]); } } }