mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-20 15:18:08 +02:00
Code Activity

[Editor] Let a free highlight be clipped when its bounding box exceeds the page limits (bug 1883632)

Browse source
This commit is contained in:
Calixte Denizet 2024-03-05 15:28:32 +01:00
parent f1272ee435
commit bd5875d066
3 changed files with 75 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

43
test/integration/highlight_editor_spec.mjs
View file

@ -1398,4 +1398,47 @@ describe("Highlight Editor", () => {
);
});
});
describe("Highlight editor mustn't be moved when close to the page limits", () => {
let pages;
beforeAll(async () => {
pages = await loadAndWait("empty.pdf", ".annotationEditorLayer");
});
afterAll(async () => {
await closePages(pages);
});
it("must check the editor coordinates", async () => {
await Promise.all(
pages.map(async ([browserName, page]) => {
await page.click("#editorHighlight");
await page.waitForSelector(".annotationEditorLayer.highlightEditing");
const rect = await page.$eval(".annotationEditorLayer", el => {
const { x, y } = el.getBoundingClientRect();
return { x, y };
});
const clickHandle = await waitForPointerUp(page);
await page.mouse.move(rect.x + 1, rect.y + 50);
await page.mouse.down();
await page.mouse.move(rect.x + 1, rect.y + 100);
await page.mouse.up();
await awaitPromise(clickHandle);
await page.waitForSelector(getEditorSelector(0));
const editorX = await page.$eval(
getEditorSelector(0),
el => el.getBoundingClientRect().x
);
expect(editorX < rect.x)
.withContext(`In ${browserName}`)
.toBeTrue();
})
);
});
});
});