mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-22 16:18:08 +02:00
Code Activity

Expose even more API-functionality in the TypeScript definitions (issue 14435, PR 14013 follow-up)

Browse source 
While `PageViewport` apparently makes sense in TypeScript environments, given that it's being returned by the `PDFPageProxy.getViewport`-method in the API, we really don't want to extend the *public* API by simply exporting the class directly in `src/pdf.js` since it should never be called/initialized manually.
Hence we follow the same pattern as in PR 14013, and also extend the API unit-tests to ensure that `PDFPageProxy.getViewport` always returns a `PageViewport`-instance as expected.
This commit is contained in:
Jonas Jenwald 2022-01-13 11:58:45 +01:00
parent ea57ef116e
commit b9849e38b8
2 changed files with 23 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/pdf.js
View file

@ -18,6 +18,7 @@
/** @typedef {import("./display/api").PDFDocumentProxy} PDFDocumentProxy */
/** @typedef {import("./display/api").PDFPageProxy} PDFPageProxy */
/** @typedef {import("./display/api").RenderTask} RenderTask */
/** @typedef {import("./display/display_utils").PageViewport} PageViewport */
import {
AnnotationMode,