mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-20 23:28:06 +02:00
Code Activity

Reduce the duplication for the document_properties_page_size_* strings, by defining the units separately

Browse source
This commit is contained in:
Jonas Jenwald 2018-03-20 13:30:55 +01:00
parent 77d025dc14
commit b7b5d93231
3 changed files with 31 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

33
web/pdf_document_properties.js
View file

@ -247,20 +247,25 @@ class PDFDocumentProperties {
const { width, height, } = pageSizeInches;
return Promise.all([
this.l10n.get('document_properties_page_size_in_2', {
width: (Math.round(width * 100) / 100).toLocaleString(),
height: (Math.round(height * 100) / 100).toLocaleString(),
}, '{{width}} × {{height}} in'),
// 1in = 25.4mm; no need to round to 2 decimals for millimeters.
this.l10n.get('document_properties_page_size_mm_2', {
width: (Math.round(width * 25.4 * 10) / 10).toLocaleString(),
height: (Math.round(height * 25.4 * 10) / 10).toLocaleString(),
}, '{{width}} × {{height}} mm'),
]).then((sizes) => {
return {
inch: sizes[0],
mm: sizes[1],
};
this.l10n.get('document_properties_page_size_unit_inches', null, 'in'),
this.l10n.get('document_properties_page_size_unit_millimeters', null,
'mm'),
]).then(([unitInches, unitMillimeters]) => {
return Promise.all([
this.l10n.get('document_properties_page_size_dimension_string', {
width: (Math.round(width * 100) / 100).toLocaleString(),
height: (Math.round(height * 100) / 100).toLocaleString(),
unit: unitInches,
}, '{{width}} × {{height}} {{unit}}'),
// 1in == 25.4mm; no need to round to 2 decimals for millimeters.
this.l10n.get('document_properties_page_size_dimension_string', {
width: (Math.round(width * 25.4 * 10) / 10).toLocaleString(),
height: (Math.round(height * 25.4 * 10) / 10).toLocaleString(),
unit: unitMillimeters,
}, '{{width}} × {{height}} {{unit}}'),
]);
}).then((sizes) => {
return { inch: sizes[0], mm: sizes[1], };
});
}