mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-23 16:48:08 +02:00
Code Activity

Merge pull request #18965 from Snuffleupagus/_goodSquareLength-static

Browse source 
Re-factor the `ImageResizer._goodSquareLength` definition
This commit is contained in:
Tim van der Meij 2024-10-27 14:38:43 +01:00 • committed by GitHub
commit b5805caacd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/core/image_resizer.js
View file

@ -32,13 +32,15 @@ const MAX_ERROR = 128;
// should be a way faster to create the bitmap.
class ImageResizer {
static #goodSquareLength = MIN_IMAGE_DIM;
constructor(imgData, isMask) {
this._imgData = imgData;
this._isMask = isMask;
}
static needsToBeResized(width, height) {
if (width <= this._goodSquareLength && height <= this._goodSquareLength) {
if (width <= this.#goodSquareLength && height <= this.#goodSquareLength) {
return false;
}
@ -52,14 +54,14 @@ class ImageResizer {
return area > this.MAX_AREA;
}
if (area < this._goodSquareLength ** 2) {
if (area < this.#goodSquareLength ** 2) {
return false;
}
// We try as much as possible to avoid to compute the max area.
if (this._areGoodDims(width, height)) {
this._goodSquareLength = Math.max(
this._goodSquareLength,
this.#goodSquareLength = Math.max(
this.#goodSquareLength,
Math.floor(Math.sqrt(width * height))
);
return false;
@ -69,13 +71,13 @@ class ImageResizer {
// some large canvas, so in the Firefox case this value (and MAX_DIM) can be
// infered from prefs (MAX_AREA = gfx.max-alloc-size / 4, 4 is because of
// RGBA).
this._goodSquareLength = this._guessMax(
this._goodSquareLength,
this.#goodSquareLength = this._guessMax(
this.#goodSquareLength,
MAX_DIM,
MAX_ERROR,
0
);
const maxArea = (this.MAX_AREA = this._goodSquareLength ** 2);
const maxArea = (this.MAX_AREA = this.#goodSquareLength ** 2);
return area > maxArea;
}
@ -93,12 +95,7 @@ class ImageResizer {
return shadow(
this,
"MAX_AREA",
this._guessMax(
ImageResizer._goodSquareLength,
this.MAX_DIM,
MAX_ERROR,
0
) ** 2
this._guessMax(this.#goodSquareLength, this.MAX_DIM, MAX_ERROR, 0) ** 2
);
}
@ -393,6 +390,4 @@ class ImageResizer {
}
}
ImageResizer._goodSquareLength = MIN_IMAGE_DIM;
export { ImageResizer };