mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 22:58:07 +02:00
Code Activity

Merge pull request #18421 from Snuffleupagus/bug-1907000

Browse source 
Allow e.g. /FitH destinations without additional parameter (bug 1907000)
This commit is contained in:
Jonas Jenwald 2024-07-11 10:51:44 +02:00 • committed by GitHub
commit b56e4209a9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 248 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/core/catalog.js
View file

@ -78,7 +78,7 @@ function isValidExplicitDest(dest) {
case "FitBH":
case "FitV":
case "FitBV":
if (args.length !== 1) {
if (args.length > 1) {
return false;
}
break;

1
test/pdfs/.gitignore vendored
View file

@ -13,6 +13,7 @@
!issue1155r.pdf
!issue2017r.pdf
!bug1727053.pdf
!bug1907000_reduced.pdf
!issue11913.pdf
!issue2391-1.pdf
!issue2391-2.pdf

202
test/pdfs/bug1907000_reduced.pdf Normal file
View file

File diff suppressed because one or more lines are too long

43
test/unit/api_spec.js
View file

@ -1901,6 +1901,49 @@ describe("api", function () {
await loadingTask.destroy();
});
it("gets outline, with /FitH destinations that lack coordinate parameter (bug 1907000)", async function () {
const loadingTask = getDocument(
buildGetDocumentParams("bug1907000_reduced.pdf")
);
const pdfDoc = await loadingTask.promise;
const outline = await pdfDoc.getOutline();
expect(outline).toEqual([
{
action: null,
attachment: undefined,
dest: [{ num: 14, gen: 0 }, { name: "FitH" }],
url: null,
unsafeUrl: undefined,
newWindow: undefined,
setOCGState: undefined,
title: "Page 1",
color: new Uint8ClampedArray([0, 0, 0]),
count: undefined,
bold: false,
italic: false,
items: [],
},
{
action: null,
attachment: undefined,
dest: [{ num: 13, gen: 0 }, { name: "FitH" }],
url: null,
unsafeUrl: undefined,
newWindow: undefined,
setOCGState: undefined,
title: "Page 2",
color: new Uint8ClampedArray([0, 0, 0]),
count: undefined,
bold: false,
italic: false,
items: [],
},
]);
await loadingTask.destroy();
});
it("gets non-existent permissions", async function () {
const permissions = await pdfDocument.getPermissions();
expect(permissions).toEqual(null);

2
web/pdf_link_service.js
View file

@ -519,7 +519,7 @@ class PDFLinkService {
case "FitBH":
case "FitV":
case "FitBV":
if (args.length !== 1) {
if (args.length > 1) {
return false;
}
break;