From d27efb43cdf2904f56ae8de9b653f6208b674702 Mon Sep 17 00:00:00 2001 From: Calixte Denizet Date: Wed, 10 Jul 2024 11:29:32 +0200 Subject: [PATCH] [Editor] Wait for 'pagerendered' to switch to editing mode The focus can potentially be stolen when the DOM is modified when adding a new canvas element for the page being redrawn. --- web/pdf_viewer.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/web/pdf_viewer.js b/web/pdf_viewer.js index 256ad0e3a..d56328014 100644 --- a/web/pdf_viewer.js +++ b/web/pdf_viewer.js @@ -2328,9 +2328,9 @@ class PDFViewer { // We must call #switchToEditAnnotationMode unconditionally to ensure that // page is rendered if it's useful or not. const idsToRefresh = this.#switchToEditAnnotationMode(); - if (isEditing && editId && idsToRefresh) { - // We're editing an existing annotation so we must switch to editing - // mode when the rendering is done. + if (isEditing && idsToRefresh) { + // We're editing so we must switch to editing mode when the rendering is + // done. this.#cleanupSwitchAnnotationEditorMode(); this.#onPageRenderedCallback = ({ pageNumber }) => { idsToRefresh.delete(pageNumber);