mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-20 23:28:06 +02:00
Code Activity

Add a parameter to the isName function that enables checking not just that something is a Name, but also that the actual name properties matches

Browse source 
This is similar to the existing `isCmd` and `isDict` functions, which already support similar kind of checks.
With the updated `isName` function, we'll be able to simplify many callsites from: `isName(someVariable) && someVariable.name === 'someName'` to: `isName(someVariable, 'someName')`.
This commit is contained in:
Jonas Jenwald 2016-08-04 14:57:31 +02:00
parent 94089960c0
commit af636aae96
2 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
test/unit/primitives_spec.js
View file

@ -244,6 +244,12 @@ describe('primitives', function() {
var name = Name.get('Font');
expect(isName(name)).toEqual(true);
});
it('handles names with name check', function () {
var name = Name.get('Font');
expect(isName(name, 'Font')).toEqual(true);
expect(isName(name, 'Subtype')).toEqual(false);
});
});
describe('isCmd', function () {