mirror of
https://github.com/mozilla/pdf.js.git
synced 2025-04-20 15:18:08 +02:00
Merge pull request #17814 from calixteman/bug1886427
[Editor] Make sure the text in the mark has null dimensions to avoid to see a meaningless rectangle in voiceover (bug 1886427)
This commit is contained in:
commit
ae60221b0e
2 changed files with 42 additions and 0 deletions
|
@ -1606,4 +1606,45 @@ describe("Highlight Editor", () => {
|
|||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("Text inside mark element", () => {
|
||||
let pages;
|
||||
|
||||
beforeAll(async () => {
|
||||
pages = await loadAndWait("tracemonkey.pdf", ".annotationEditorLayer");
|
||||
});
|
||||
|
||||
afterAll(async () => {
|
||||
await closePages(pages);
|
||||
});
|
||||
|
||||
it("must have null dimensions", async () => {
|
||||
await Promise.all(
|
||||
pages.map(async ([browserName, page]) => {
|
||||
await page.click("#editorHighlight");
|
||||
await page.waitForSelector(".annotationEditorLayer.highlightEditing");
|
||||
|
||||
const rect = await getSpanRectFromText(page, 1, "Abstract");
|
||||
const x = rect.x + rect.width / 2;
|
||||
const y = rect.y + rect.height / 2;
|
||||
await page.mouse.click(x, y, { count: 2, delay: 100 });
|
||||
await page.waitForSelector(getEditorSelector(0));
|
||||
|
||||
const [w, h] = await page.evaluate(
|
||||
sel => {
|
||||
const mark = document.querySelector(sel);
|
||||
const range = document.createRange();
|
||||
range.selectNodeContents(mark);
|
||||
const { width, height } = range.getClientRects()[0];
|
||||
return [width, height];
|
||||
},
|
||||
`${getEditorSelector(0)} mark`
|
||||
);
|
||||
|
||||
expect(w).withContext(`In ${browserName}`).toEqual(0);
|
||||
expect(h).withContext(`In ${browserName}`).toEqual(0);
|
||||
})
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue