mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-22 16:18:08 +02:00
Code Activity

Merge pull request #18879 from calixteman/highlight_hover

Browse source 
Don't add the grey outline when hovering a selected highlight
This commit is contained in:
calixteman 2024-10-10 15:28:59 +02:00 • committed by GitHub
commit a77bf87c50
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/display/editor/annotation_editor_layer.js
View file

@ -734,14 +734,6 @@ class AnnotationEditorLayer {
this.#uiManager.toggleSelected(editor);
}
/**
* Check if the editor is selected.
* @param {AnnotationEditor} editor
*/
isSelected(editor) {
return this.#uiManager.isSelected(editor);
}
/**
* Unselect an editor.
* @param {AnnotationEditor} editor

6
src/display/editor/editor.js
View file

@ -1109,6 +1109,10 @@ class AnnotationEditor {
this.#selectOnPointerEvent(event);
}
get isSelected() {
return this._uiManager.isSelected(this);
}
#selectOnPointerEvent(event) {
const { isMac } = FeatureTest.platform;
if (
@ -1123,7 +1127,7 @@ class AnnotationEditor {
}
#setUpDragSession(event) {
const isSelected = this._uiManager.isSelected(this);
const { isSelected } = this;
this._uiManager.setUpDragSession();
const ac = new AbortController();

8
src/display/editor/highlight.js
View file

@ -596,11 +596,15 @@ class HighlightEditor extends AnnotationEditor {
}
pointerover() {
this.parent.drawLayer.addClass(this.#outlineId, "hovered");
if (!this.isSelected) {
this.parent.drawLayer.addClass(this.#outlineId, "hovered");
}
}
pointerleave() {
this.parent.drawLayer.removeClass(this.#outlineId, "hovered");
if (!this.isSelected) {
this.parent.drawLayer.removeClass(this.#outlineId, "hovered");
}
}
#keydown(event) {