mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-26 10:08:06 +02:00
Code Activity

Ensure that Dict.set only accepts string keys

Browse source 
Trying to use a non-string `key` in a `Dict` is not intended, and would basically be an implementation error. Hence we can add a non-PRODUCTION check to enforce this, complementing the existing `value` check added in PR 11672.
This commit is contained in:
Jonas Jenwald 2022-02-22 15:52:12 +01:00
parent b2f6844ce3
commit a2f9031e9a
4 changed files with 20 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/core/document.js
View file

@ -1187,7 +1187,7 @@ class PDFDocument {
} else {
info(`Bad value in document info for "${key}".`);
}
} else if (typeof key === "string") {
} else {
// For custom values, only accept white-listed types to prevent
// errors that would occur when trying to send non-serializable
// objects to the main-thread (for example `Dict` or `Stream`).