From a24ad28d751f82ed1d3777d1a336a3b76c915d15 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Tue, 24 Mar 2020 14:12:10 +0100
Subject: [PATCH] Rename `BaseViewer._setDocumentViewerElement` to
 `BaseViewer._viewerElement`

It was pointed out the the old name felt confusing, so let's just rename the getter since it's an internal property anyway.
---
 web/base_viewer.js            | 6 +++---
 web/pdf_single_page_viewer.js | 4 ++--
 web/pdf_viewer.js             | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/web/base_viewer.js b/web/base_viewer.js
index 3b07953b2..f57cafe66 100644
--- a/web/base_viewer.js
+++ b/web/base_viewer.js
@@ -391,9 +391,9 @@ class BaseViewer {
   /**
    * @private
    */
-  get _setDocumentViewerElement() {
+  get _viewerElement() {
     // In most viewers, e.g. `PDFViewer`, this should return `this.viewer`.
-    throw new Error("Not implemented: _setDocumentViewerElement");
+    throw new Error("Not implemented: _viewerElement");
   }
 
   /**
@@ -479,7 +479,7 @@ class BaseViewer {
 
         for (let pageNum = 1; pageNum <= pagesCount; ++pageNum) {
           const pageView = new PDFPageView({
-            container: this._setDocumentViewerElement,
+            container: this._viewerElement,
             eventBus: this.eventBus,
             id: pageNum,
             scale,
diff --git a/web/pdf_single_page_viewer.js b/web/pdf_single_page_viewer.js
index 3db66f3b1..1e835897d 100644
--- a/web/pdf_single_page_viewer.js
+++ b/web/pdf_single_page_viewer.js
@@ -27,12 +27,12 @@ class PDFSinglePageViewer extends BaseViewer {
     });
   }
 
-  get _setDocumentViewerElement() {
+  get _viewerElement() {
     // Since we only want to display *one* page at a time when using the
     // `PDFSinglePageViewer`, we cannot append them to the `viewer` DOM element.
     // Instead, they are placed in a `DocumentFragment`, and only the current
     // page is displayed in the viewer (refer to `this._ensurePageViewVisible`).
-    return shadow(this, "_setDocumentViewerElement", this._shadowViewer);
+    return shadow(this, "_viewerElement", this._shadowViewer);
   }
 
   _resetView() {
diff --git a/web/pdf_viewer.js b/web/pdf_viewer.js
index fcf0e1ac5..e7965f37b 100644
--- a/web/pdf_viewer.js
+++ b/web/pdf_viewer.js
@@ -17,8 +17,8 @@ import { BaseViewer } from "./base_viewer.js";
 import { shadow } from "pdfjs-lib";
 
 class PDFViewer extends BaseViewer {
-  get _setDocumentViewerElement() {
-    return shadow(this, "_setDocumentViewerElement", this.viewer);
+  get _viewerElement() {
+    return shadow(this, "_viewerElement", this.viewer);
   }
 
   _scrollIntoView({ pageDiv, pageSpot = null, pageNumber = null }) {