mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-26 10:08:06 +02:00
Code Activity

Ensure that PDFDocument.checkFirstPage waits for cleanup to complete (PR 10392 follow-up)

Browse source 
Given how this method is currently used there shouldn't be any fonts loaded at the point in time where it's called, but it does seem like a bad idea to assume that that's always going to be the case. Since `PDFDocument.checkFirstPage` is already asynchronous, it's easy enough to simply await `Catalog.cleanup` here.

(The patch also makes a tiny simplification in a loop in `Catalog.cleanup`.)
This commit is contained in:
Jonas Jenwald 2019-12-07 12:20:26 +01:00
parent 514b500a6c
commit a02122e984
2 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/core/obj.js
View file

@ -671,9 +671,8 @@ class Catalog {
});
return Promise.all(promises).then((translatedFonts) => {
for (let i = 0, ii = translatedFonts.length; i < ii; i++) {
const font = translatedFonts[i].dict;
delete font.translated;
for (const { dict, } of translatedFonts) {
delete dict.translated;
}
this.fontCache.clear();
this.builtInCMapCache.clear();