mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-23 08:38:06 +02:00
Code Activity

Use fewer hasFieldFlag calls in the src/core/annotation.js file

Browse source 
We lookup a number of field-flags multiple times, which seems unnecessary.
This commit is contained in:
Jonas Jenwald 2025-01-30 13:38:57 +01:00
parent 42c2b7b657
commit 9e227de3c5
1 changed files with 8 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/core/annotation.js
View file

@ -2774,8 +2774,8 @@ class TextWidgetAnnotation extends WidgetAnnotation {
this.data.multiLine = this.hasFieldFlag(AnnotationFieldFlag.MULTILINE);
this.data.comb =
this.hasFieldFlag(AnnotationFieldFlag.COMB) &&
!this.hasFieldFlag(AnnotationFieldFlag.MULTILINE) &&
!this.hasFieldFlag(AnnotationFieldFlag.PASSWORD) &&
!this.data.multiLine &&
!this.data.password &&
!this.hasFieldFlag(AnnotationFieldFlag.FILESELECT) &&
this.data.maxLen !== 0;
this.data.doNotScroll = this.hasFieldFlag(AnnotationFieldFlag.DONOTSCROLL);
@ -2986,13 +2986,12 @@ class ButtonWidgetAnnotation extends WidgetAnnotation {
this.checkedAppearance = null;
this.uncheckedAppearance = null;
this.data.checkBox =
!this.hasFieldFlag(AnnotationFieldFlag.RADIO) &&
!this.hasFieldFlag(AnnotationFieldFlag.PUSHBUTTON);
this.data.radioButton =
this.hasFieldFlag(AnnotationFieldFlag.RADIO) &&
!this.hasFieldFlag(AnnotationFieldFlag.PUSHBUTTON);
this.data.pushButton = this.hasFieldFlag(AnnotationFieldFlag.PUSHBUTTON);
const isRadio = this.hasFieldFlag(AnnotationFieldFlag.RADIO),
isPushButton = this.hasFieldFlag(AnnotationFieldFlag.PUSHBUTTON);
this.data.checkBox = !isRadio && !isPushButton;
this.data.radioButton = isRadio && !isPushButton;
this.data.pushButton = isPushButton;
this.data.isTooltipOnly = false;
if (this.data.checkBox) {